Address feedback

Author: devversion

src/lib/core/overlay/position/connected-position-strategy.spec.ts

@@ -41,11 +41,7 @@ describe('ConnectedPositionStrategy', () => {
     let overlayContainerElement: HTMLElement;
     let strategy: ConnectedPositionStrategy;
     let fakeElementRef: ElementRef;
-    // TODO: The `any` type is used here because the FakeViewportRuler can't extend or implement
-    // the real ViewportRuler class because Typescript complains when using a class as an interface.
-    // Also we don't want to extend the ViewportRuler because we'd need to call the constructor
-    // in the superclass. In short: We should use Dependency Injection to fake the ViewportRuler.
-    let fakeViewportRuler: any;
+    let fakeViewportRuler: FakeViewportRuler;
     let positionBuilder: OverlayPositionBuilder;
 
     let originRect: ClientRect;
@@ -592,7 +588,7 @@ function createOverflowContainerElement() {
 
 
 /** Fake implementation of ViewportRuler that just returns the previously given ClientRect. */
-class FakeViewportRuler {
+class FakeViewportRuler implements ViewportRuler {
   fakeRect: ClientRect = {left: 0, top: 0, width: 1014, height: 686, bottom: 686, right: 1014};
   fakeScrollPos: {top: number, left: number} = {top: 0, left: 0};
 

src/lib/core/overlay/position/viewport-ruler.spec.ts

@@ -42,7 +42,8 @@ describe('ViewportRuler', () => {
     document.body.appendChild(veryLargeElement);
 
     scrollTo(1500, 2000);
-    ruler.updateDocumentRectangle();
+    // Force an update of the cached viewport geometries because IE11 emits the scroll event later.
+    ruler._cacheViewportGeometry();
 
     let bounds = ruler.getViewportRect();
 
@@ -79,7 +80,8 @@ describe('ViewportRuler', () => {
     document.body.appendChild(veryLargeElement);
 
     scrollTo(1500, 2000);
-    ruler.updateDocumentRectangle();
+    // Force an update of the cached viewport geometries because IE11 emits the scroll event later.
+    ruler._cacheViewportGeometry();
 
     // In the iOS simulator (BrowserStack & SauceLabs), adding the content to the
     // body causes karma's iframe for the test to stretch to fit that content once we attempt to

src/lib/core/overlay/position/viewport-ruler.ts

@@ -11,17 +11,14 @@ import {ScrollDispatcher} from '../scroll/scroll-dispatcher';
 export class ViewportRuler {
 
   /** Cached document client rectangle. */
-  private _documentRect: ClientRect;
+  private _documentRect?: ClientRect;
 
   constructor(scrollDispatcher: ScrollDispatcher) {
-
-    // Initially update the document rectangle.
-    this.updateDocumentRectangle();
+    // Initially cache the document rectangle.
+    this._cacheViewportGeometry();
 
     // Subscribe to scroll and resize events and update the document rectangle on changes.
-    scrollDispatcher
-      .scrolled()
-      .subscribe(() => this.updateDocumentRectangle());
+    scrollDispatcher.scrolled().subscribe(() => this._cacheViewportGeometry());
   }
 
   /** Gets a ClientRect for the viewport's bounds. */
@@ -68,10 +65,9 @@ export class ViewportRuler {
   }
 
   /**
-   * @internal
-   * Updates the cached client rectangle of the document element.
+   * Caches the latest client rectangle of the document element.
    */
-  updateDocumentRectangle() {
+  _cacheViewportGeometry?() {
     this._documentRect = document.documentElement.getBoundingClientRect();
   }
 

src/lib/core/ripple/ripple.spec.ts

@@ -232,8 +232,9 @@ describe('MdRipple', () => {
         document.documentElement.scrollTop = pageScrollTop;
         // Mobile safari
         window.scrollTo(pageScrollLeft, pageScrollTop);
-        // Force an update of the cached rectangle in the ViewportRuler.
-        viewportRuler.updateDocumentRectangle();
+        // Force an update of the cached viewport geometries because IE11 emits the
+        // scroll event later.
+        viewportRuler._cacheViewportGeometry();
       });
 
       afterEach(() => {
@@ -245,8 +246,9 @@ describe('MdRipple', () => {
         document.documentElement.scrollTop = 0;
         // Mobile safari
         window.scrollTo(0, 0);
-        // Force an update of the cached rectangle in the ViewportRuler.
-        viewportRuler.updateDocumentRectangle();
+        // Force an update of the cached viewport geometries because IE11 emits the
+        // scroll event later.
+        viewportRuler._cacheViewportGeometry();
       });
 
       it('create ripple with correct position', () => {