Skip to content

Commit e721a5d

Browse files
josephperrottalxhub
authored andcommitted
fix(benchpress): update type castings for JSON.parse usage (#40710)
Update usages of JSON.parse to be cast as specific types. PR Close #40710
1 parent f728490 commit e721a5d

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

packages/benchpress/src/webdriver/chrome_driver_extension.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export class ChromeDriverExtension extends WebDriverExtension {
8686
.then((entries) => {
8787
const events: PerfLogEvent[] = [];
8888
entries.forEach((entry: any) => {
89-
const message = JSON.parse(entry['message'])['message'];
89+
const message = (JSON.parse(entry['message']) as {message: any})['message'];
9090
if (message['method'] === 'Tracing.dataCollected') {
9191
events.push(message['params']);
9292
}

packages/benchpress/src/webdriver/ios_driver_extension.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export class IOsDriverExtension extends WebDriverExtension {
4444
.then((entries) => {
4545
const records: any[] = [];
4646
entries.forEach((entry: any) => {
47-
const message = JSON.parse(entry['message'])['message'];
47+
const message = (JSON.parse(entry['message']) as {message: any})['message'];
4848
if (message['method'] === 'Timeline.eventRecorded') {
4949
records.push(message['params']['record']);
5050
}

packages/benchpress/test/reporter/json_file_reporter_spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ import {Injector, JsonFileReporter, MeasureValues, Options, SampleDescription} f
5050
[mv(0, 0, {'a': 3, 'b': 6}), mv(1, 1, {'a': 5, 'b': 9})]);
5151
const regExp = /somePath\/someId_\d+\.json/;
5252
expect(loggedFile['filename'].match(regExp) != null).toBe(true);
53-
const parsedContent = JSON.parse(loggedFile['content']);
53+
const parsedContent = JSON.parse(loggedFile['content']) as any;
5454
expect(parsedContent).toEqual({
5555
'description': {
5656
'id': 'someId',

0 commit comments

Comments
 (0)