refactor(core): remove TODOs referencing #24571 (#60648)

JeanMeche · thePunderWoman · commit 38557304e3c6 · 2025-03-31T20:24:30.000Z
Fixing those todos are now mostly breaking changes. The situation is "good" as is. PR Close #60648
diff --git a/packages/common/http/src/headers.ts b/packages/common/http/src/headers.ts
@@ -23,7 +23,6 @@ export class HttpHeaders {
   /**
    * Internal map of lowercase header names to values.
    */
-  // TODO(issue/24571): remove '!'.
   private headers!: Map<string, string[]>;
 
   /**
diff --git a/packages/common/http/src/request.ts b/packages/common/http/src/request.ts
@@ -186,7 +186,6 @@ export class HttpRequest<T> {
    * new HttpParams({fromString: 'angular=awesome'})
    * ```
    */
-  // TODO(issue/24571): remove '!'.
   readonly params!: HttpParams;
 
   /**
diff --git a/packages/common/http/src/response.ts b/packages/common/http/src/response.ts
@@ -183,7 +183,6 @@ export abstract class HttpResponseBase {
   /**
    * Type of the response, narrowed to either the full response or the header.
    */
-  // TODO(issue/24571): remove '!'.
   readonly type!: HttpEventType.Response | HttpEventType.ResponseHeader;
 
   /**
diff --git a/packages/common/http/test/jsonp_mock.ts b/packages/common/http/test/jsonp_mock.ts
@@ -28,7 +28,6 @@ export class MockScriptElement {
 }
 
 export class MockDocument {
-  // TODO(issue/24571): remove '!'.
   mock!: MockScriptElement | null;
   readonly body: any = this;
 
diff --git a/packages/common/http/test/xhr_mock.ts b/packages/common/http/test/xhr_mock.ts
@@ -10,7 +10,6 @@ import {XhrFactory} from '@angular/common';
 import {HttpHeaders} from '@angular/common/http/src/headers';
 
 export class MockXhrFactory implements XhrFactory {
-  // TODO(issue/24571): remove '!'.
   mock!: MockXMLHttpRequest;
 
   build(): XMLHttpRequest {
@@ -33,9 +32,7 @@ export class MockXMLHttpRequestUpload {
 export class MockXMLHttpRequest {
   // Set by method calls.
   body: any;
-  // TODO(issue/24571): remove '!'.
   method!: string;
-  // TODO(issue/24571): remove '!'.
   url!: string;
   mockHeaders: {[key: string]: string} = {};
   mockAborted: boolean = false;
diff --git a/packages/common/src/directives/ng_for_of.ts b/packages/common/src/directives/ng_for_of.ts
@@ -214,7 +214,6 @@ export class NgForOf<T, U extends NgIterable<T> = NgIterable<T>> implements DoCh
   private _ngForOf: U | undefined | null = null;
   private _ngForOfDirty: boolean = true;
   private _differ: IterableDiffer<T> | null = null;
-  // TODO(issue/24571): remove '!'
   // waiting for microsoft/typescript#43662 to allow the return type `TrackByFunction|undefined` for
   // the getter
   private _trackByFn!: TrackByFunction<T>;
diff --git a/packages/examples/core/animation/ts/dsl/animation_example.ts b/packages/examples/core/animation/ts/dsl/animation_example.ts
@@ -42,7 +42,6 @@ import {BrowserAnimationsModule} from '@angular/platform-browser/animations';
   standalone: false,
 })
 export class MyExpandoCmp {
-  // TODO(issue/24571): remove '!'.
   stateExpression!: string;
   constructor() {
     this.collapse();
diff --git a/packages/forms/src/directives/abstract_form_group_directive.ts b/packages/forms/src/directives/abstract_form_group_directive.ts
@@ -30,7 +30,6 @@ export class AbstractFormGroupDirective extends ControlContainer implements OnIn
    *
    * @internal
    */
-  // TODO(issue/24571): remove '!'.
   _parent!: ControlContainer;
 
   /** @nodoc */
diff --git a/packages/forms/src/directives/control_container.ts b/packages/forms/src/directives/control_container.ts
@@ -21,7 +21,6 @@ export abstract class ControlContainer extends AbstractControlDirective {
    * @description
    * The name for the control
    */
-  // TODO(issue/24571): remove '!'.
   name!: string | number | null;
 
   /**
diff --git a/packages/forms/src/directives/ng_form.ts b/packages/forms/src/directives/ng_form.ts
@@ -160,7 +160,6 @@ export class NgForm extends ControlContainer implements Form, AfterViewInit {
    * Possible values: `'change'` | `'blur'` | `'submit'`.
    *
    */
-  // TODO(issue/24571): remove '!'.
   @Input('ngFormOptions') options!: {updateOn?: FormHooks};
 
   constructor(
diff --git a/packages/forms/src/directives/ng_model.ts b/packages/forms/src/directives/ng_model.ts
@@ -196,7 +196,6 @@ export class NgModel extends NgControl implements OnChanges, OnDestroy {
    * @description
    * Tracks whether the control is disabled.
    */
-  // TODO(issue/24571): remove '!'.
   @Input('disabled') isDisabled!: boolean;
 
   /**
@@ -221,7 +220,6 @@ export class NgModel extends NgControl implements OnChanges, OnDestroy {
    * Defaults to 'change'. Possible values: `'change'` | `'blur'` | `'submit'`.
    *
    */
-  // TODO(issue/24571): remove '!'.
   @Input('ngModelOptions') options!: {name?: string; standalone?: boolean; updateOn?: FormHooks};
 
   /**
diff --git a/packages/forms/src/directives/radio_control_value_accessor.ts b/packages/forms/src/directives/radio_control_value_accessor.ts
@@ -131,13 +131,10 @@ export class RadioControlValueAccessor
   implements ControlValueAccessor, OnDestroy, OnInit
 {
   /** @internal */
-  // TODO(issue/24571): remove '!'.
   _state!: boolean;
   /** @internal */
-  // TODO(issue/24571): remove '!'.
   _control!: NgControl;
   /** @internal */
-  // TODO(issue/24571): remove '!'.
   _fn!: Function;
 
   private setDisabledStateFired = false;
@@ -155,15 +152,13 @@ export class RadioControlValueAccessor
    * @description
    * Tracks the name of the radio input element.
    */
-  // TODO(issue/24571): remove '!'.
   @Input() name!: string;
 
   /**
    * @description
    * Tracks the name of the `FormControl` bound to the directive. The name corresponds
    * to a key in the parent `FormGroup` or `FormArray`.
    */
-  // TODO(issue/24571): remove '!'.
   @Input() formControlName!: string;
 
   /**
diff --git a/packages/forms/src/directives/reactive_directives/form_control_directive.ts b/packages/forms/src/directives/reactive_directives/form_control_directive.ts
@@ -88,7 +88,6 @@ export class FormControlDirective extends NgControl implements OnChanges, OnDest
    * @description
    * Tracks the `FormControl` instance bound to the directive.
    */
-  // TODO(issue/24571): remove '!'.
   @Input('formControl') form!: FormControl;
 
   /**
diff --git a/packages/forms/src/directives/reactive_directives/form_control_name.ts b/packages/forms/src/directives/reactive_directives/form_control_name.ts
@@ -96,7 +96,6 @@ export class FormControlName extends NgControl implements OnChanges, OnDestroy {
    * @description
    * Tracks the `FormControl` instance bound to the directive.
    */
-  // TODO(issue/24571): remove '!'.
   override readonly control!: FormControl;
 
   /**
diff --git a/packages/forms/src/directives/select_control_value_accessor.ts b/packages/forms/src/directives/select_control_value_accessor.ts
@@ -198,7 +198,6 @@ export class NgSelectOption implements OnDestroy {
    * @description
    * ID of the option element
    */
-  // TODO(issue/24571): remove '!'.
   id!: string;
 
   constructor(
diff --git a/packages/forms/src/directives/select_multiple_control_value_accessor.ts b/packages/forms/src/directives/select_multiple_control_value_accessor.ts
@@ -44,19 +44,6 @@ function _extractId(valueString: string): string {
   return valueString.split(':')[0];
 }
 
-/** Mock interface for HTML Options */
-interface HTMLOption {
-  value: string;
-  selected: boolean;
-}
-
-/** Mock interface for HTMLCollection */
-abstract class HTMLCollection {
-  // TODO(issue/24571): remove '!'.
-  length!: number;
-  abstract item(_: number): HTMLOption;
-}
-
 /**
  * @description
  * The `ControlValueAccessor` for writing multi-select control values and listening to multi-select
@@ -226,7 +213,6 @@ export class SelectMultipleControlValueAccessor
   standalone: false,
 })
 export class ɵNgSelectMultipleOption implements OnDestroy {
-  // TODO(issue/24571): remove '!'.
   id!: string;
   /** @internal */
   _value: any;

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,6 @@ export class MockScriptElement {`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`export class MockDocument {`
`31`		`- // TODO(issue/24571): remove '!'.`
`32`	`31`	`mock!: MockScriptElement \| null;`
`33`	`32`	`readonly body: any = this;`
`34`	`33`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,6 @@ export class AbstractFormGroupDirective extends ControlContainer implements OnIn`
`30`	`30`	`*`
`31`	`31`	`* @internal`
`32`	`32`	`*/`
`33`		`- // TODO(issue/24571): remove '!'.`
`34`	`33`	`_parent!: ControlContainer;`
`35`	`34`
`36`	`35`	`/** @nodoc */`
Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,6 @@ export class NgForm extends ControlContainer implements Form, AfterViewInit {`
`160`	`160`	* Possible values: `'change'` \| `'blur'` \| `'submit'`.
`161`	`161`	`*`
`162`	`162`	`*/`
`163`		`- // TODO(issue/24571): remove '!'.`
`164`	`163`	`@Input('ngFormOptions') options!: {updateOn?: FormHooks};`
`165`	`164`
`166`	`165`	`constructor(`