fix(@angular/ssr): ensure server-side navigation triggers a redirect #31497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
force-pushed
the
navigation-initial-url
branch
from
dbdf556 to
0d20150
Compare
alan-agius4
force-pushed
the
navigation-initial-url
branch
from
0d20150 to
53180a8
Compare
alan-agius4
force-pushed
the
navigation-initial-url
branch
4 times, most recently
from
cf9f7db to
d9dc146
Compare
alan-agius4
force-pushed
the
navigation-initial-url
branch
from
d9dc146 to
27ffba9
Compare
atscott
previously requested changes
Oct 16, 2025
| const pendingTasks = inject(PendingTasks); | ||
|
|
||
| pendingTasks.run(() => | ||
| router.navigate([], { |
Contributor
There was a problem hiding this comment.
Can we maybe do this in a guard instead? As discussed, I don’t love that this causes the navigation to not complete successfully.
Collaborator
Author
There was a problem hiding this comment.
I tried to keep this spec case as similar to the reported issue as possible.
Contributor
There was a problem hiding this comment.
Yea, I get that. Can you double check that this actually does also happen (as in it doesn’t work as a redirect) for navigations in guards? By far, that’s more common so at the very least, you’d want to cover that case too. This test is good on its own, it’s just that I wish it already worked correctly with the old code and didn’t need this PR
Collaborator
Author
There was a problem hiding this comment.
Without this change, within a guard the navigation change does not work as a redirect.
alan-agius4
force-pushed
the
navigation-initial-url
branch
from
27ffba9 to
305aaa1
Compare
alan-agius4
force-pushed
the
navigation-initial-url
branch
2 times, most recently
from
4bea198 to
336a6c6
Compare
When a navigation occurs on the server-side, such as using `router.navigate`, and the final URL is different from the initial URL that was requested, the server should respond with a redirect. Previously, the initial URL was being read from `router.lastSuccessfulNavigation.initialUrl`, which could be incorrect in scenarios involving server-side navigations, causing the comparison with the final URL to fail and preventing the redirect. This change ensures that the initial URL requested by the browser is used for the comparison, correctly triggering a redirect when necessary. Closes angular#31482
alan-agius4
force-pushed
the
navigation-initial-url
branch
from
336a6c6 to
9c3a689
Compare
atscott
approved these changes
Oct 16, 2025
alan-agius4
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a navigation occurs on the server-side, such as using
router.navigate, and the final URL is different from the initial URL that was requested, the server should respond with a redirect.Previously, the initial URL was being read from
router.lastSuccessfulNavigation.initialUrl, which could be incorrect in scenarios involving server-side navigations, causing the comparison with the final URL to fail and preventing the redirect.This change ensures that the initial URL requested by the browser is used for the comparison, correctly triggering a redirect when necessary.
Closes #31482