Skip to content

fix: throw error if the param being passed to ctx.contract.create function is not detected to be a contract #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix: throw error if the param being passed to ctx.contract.create function is not detected to be a contract #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/subcontexts/contract-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,20 +155,20 @@ export class ContractContext {
}

private isArc4<T extends BaseContract>(type: IConstructor<T>): boolean {
// TODO: uncomment the following line once version puya-ts 1.0.0 is released
// return (type as DeliberateAny as typeof BaseContract).isArc4 ?? false

const result = (type as DeliberateAny as typeof BaseContract).isArc4
if (result !== undefined && result !== null) {
return result
}
// TODO: uncomment the following line once version puya-ts 1.0.0 is released and delete the rest of the function
// throw new internal.errors.CodeError('Cannot create a contract for class as it does not extend Contract or BaseContract')

const proto = Object.getPrototypeOf(type)
if (proto === BaseContract) {
return false
} else if (proto === Contract) {
return true
} else if (proto === null) {
return false
} else if (proto === Object || proto === null) {
throw new internal.errors.CodeError('Cannot create a contract for class as it does not extend Contract or BaseContract')
}
return this.isArc4(proto)
}
Expand Down
Loading