Merge pull request #34 from algorandfoundation/fix/is-arc4

fix: throw error if the param being passed to ctx.contract.create function is not detected to be a contract

Author: boblat

src/subcontexts/contract-context.ts

@@ -155,20 +155,20 @@ export class ContractContext {
   }
 
   private isArc4<T extends BaseContract>(type: IConstructor<T>): boolean {
-    // TODO: uncomment the following line once version puya-ts 1.0.0 is released
-    // return (type as DeliberateAny as typeof BaseContract).isArc4 ?? false
-
     const result = (type as DeliberateAny as typeof BaseContract).isArc4
     if (result !== undefined && result !== null) {
       return result
     }
+    // TODO: uncomment the following line once version puya-ts 1.0.0 is released and delete the rest of the function
+    // throw new internal.errors.CodeError('Cannot create a contract for class as it does not extend Contract or BaseContract')
+
     const proto = Object.getPrototypeOf(type)
     if (proto === BaseContract) {
       return false
     } else if (proto === Contract) {
       return true
-    } else if (proto === null) {
-      return false
+    } else if (proto === Object || proto === null) {
+      throw new internal.errors.CodeError('Cannot create a contract for class as it does not extend Contract or BaseContract')
     }
     return this.isArc4(proto)
   }