fix: Don't log result of program method even on arc4 contracts

tristanmenzel · tristanmenzel · commit 0fc5cbd33418 · 2024-10-04T10:41:31.000-07:00
diff --git a/src/subcontexts/contract-context.ts b/src/subcontexts/contract-context.ts
@@ -142,7 +142,7 @@ export class ContractContext {
                 const txns = [...(transactions ?? []), appTxn]
                 return lazyContext.txn.ensureScope(txns).execute(() => {
                   const returnValue = (orig as DeliberateAny).apply(target, args)
-                  if (isArc4 && returnValue !== undefined) {
+                  if (!isProgramMethod && isArc4 && returnValue !== undefined) {
                     appTxn.logArc4ReturnValue(returnValue)
                   }
                   return returnValue

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ export class ContractContext {`
`142`	`142`	`const txns = [...(transactions ?? []), appTxn]`
`143`	`143`	`return lazyContext.txn.ensureScope(txns).execute(() => {`
`144`	`144`	`const returnValue = (orig as DeliberateAny).apply(target, args)`
`145`		`- if (isArc4 && returnValue !== undefined) {`
	`145`	`+ if (!isProgramMethod && isArc4 && returnValue !== undefined) {`
`146`	`146`	`appTxn.logArc4ReturnValue(returnValue)`
`147`	`147`	`}`
`148`	`148`	`return returnValue`