refactor: add @typescript-eslint/consistent-type-imports rule for consistent type import

Author: boblat

eslint.config.mjs

@@ -1,8 +1,8 @@
+import { FlatCompat } from '@eslint/eslintrc'
+import js from '@eslint/js'
 import globals from 'globals'
 import path from 'node:path'
 import { fileURLToPath } from 'node:url'
-import js from '@eslint/js'
-import { FlatCompat } from '@eslint/eslintrc'
 
 const __filename = fileURLToPath(import.meta.url)
 const __dirname = path.dirname(__filename)
@@ -33,5 +33,8 @@ export default [
         ...globals.node,
       },
     },
+    rules: {
+      '@typescript-eslint/consistent-type-imports': 'error',
+    },
   },
 ]

examples/calculator/contract.algo.ts

@@ -1,4 +1,5 @@
-import { assert, BaseContract, Bytes, err, log, op, Txn, uint64, Uint64 } from '@algorandfoundation/algorand-typescript'
+import type { uint64 } from '@algorandfoundation/algorand-typescript'
+import { assert, BaseContract, Bytes, err, log, op, Txn, Uint64 } from '@algorandfoundation/algorand-typescript'
 
 const ADD = Uint64(1)
 const SUB = Uint64(2)

examples/htlc-logicsig/signature.algo.ts

@@ -1,4 +1,5 @@
-import { Account, Bytes, Global, LogicSig, op, TransactionType, Txn, Uint64, uint64 } from '@algorandfoundation/algorand-typescript'
+import type { uint64 } from '@algorandfoundation/algorand-typescript'
+import { Account, Bytes, Global, LogicSig, op, TransactionType, Txn, Uint64 } from '@algorandfoundation/algorand-typescript'
 
 export default class HashedTimeLockedLogicSig extends LogicSig {
   program(): boolean | uint64 {

examples/scratch-storage/contract.algo.ts

@@ -1,4 +1,5 @@
-import { arc4, assert, BaseContract, Bytes, op, uint64, Uint64 } from '@algorandfoundation/algorand-typescript'
+import type { uint64 } from '@algorandfoundation/algorand-typescript'
+import { arc4, assert, BaseContract, Bytes, op, Uint64 } from '@algorandfoundation/algorand-typescript'
 
 export class ScratchSlotsContract extends arc4.Contract {
   @arc4.abimethod()

examples/zk-whitelist/contract.algo.ts

@@ -1,3 +1,4 @@
+import type { uint64 } from '@algorandfoundation/algorand-typescript'
 import {
   abimethod,
   Account,
@@ -13,7 +14,6 @@ import {
   OpUpFeeSource,
   TemplateVar,
   Txn,
-  uint64,
 } from '@algorandfoundation/algorand-typescript'
 
 const curveMod = 21888242871839275222246405745257275088548364400416034343698204186575808495617n

src/abi-metadata.ts

@@ -1,9 +1,9 @@
-import { BaseContract, Contract } from '@algorandfoundation/algorand-typescript'
-import { AbiMethodConfig, BareMethodConfig, CreateOptions, OnCompleteActionStr } from '@algorandfoundation/algorand-typescript/arc4'
+import type { BaseContract, Contract } from '@algorandfoundation/algorand-typescript'
+import type { AbiMethodConfig, BareMethodConfig, CreateOptions, OnCompleteActionStr } from '@algorandfoundation/algorand-typescript/arc4'
 import js_sha512 from 'js-sha512'
-import { TypeInfo } from './encoders'
+import type { TypeInfo } from './encoders'
 import { getArc4TypeName as getArc4TypeNameForARC4Encoded } from './impl/encoded-types'
-import { DeliberateAny } from './typescript-helpers'
+import type { DeliberateAny } from './typescript-helpers'
 
 export interface AbiMetadata {
   methodName: string

src/collections/custom-key-map.ts

@@ -1,5 +1,6 @@
-import { type Account, internal } from '@algorandfoundation/algorand-typescript'
-import { DeliberateAny } from '../typescript-helpers'
+import type { Account } from '@algorandfoundation/algorand-typescript'
+import { internal } from '@algorandfoundation/algorand-typescript'
+import type { DeliberateAny } from '../typescript-helpers'
 import { asBytesCls, asUint64Cls } from '../util'
 
 type Primitive = number | bigint | string | boolean

src/context-helpers/context-util.ts

@@ -1,5 +1,6 @@
-import { internal, uint64 } from '@algorandfoundation/algorand-typescript'
-import { AbiMetadata } from '../abi-metadata'
+import type { uint64 } from '@algorandfoundation/algorand-typescript'
+import { internal } from '@algorandfoundation/algorand-typescript'
+import type { AbiMetadata } from '../abi-metadata'
 import { ApplicationTransaction } from '../impl/transactions'
 import { lazyContext } from './internal-context'
 

src/context-helpers/internal-context.ts

@@ -1,8 +1,9 @@
-import { type Account, BaseContract, internal } from '@algorandfoundation/algorand-typescript'
-import { AccountData, ApplicationData, AssetData } from '../impl/reference'
-import { VoterData } from '../impl/voter-params'
-import { TransactionGroup } from '../subcontexts/transaction-context'
-import { TestExecutionContext } from '../test-execution-context'
+import type { Account } from '@algorandfoundation/algorand-typescript'
+import { BaseContract, internal } from '@algorandfoundation/algorand-typescript'
+import type { AccountData, ApplicationData, AssetData } from '../impl/reference'
+import type { VoterData } from '../impl/voter-params'
+import type { TransactionGroup } from '../subcontexts/transaction-context'
+import type { TestExecutionContext } from '../test-execution-context'
 
 /**
  * For accessing implementation specific functions, with a convenient single entry

src/decode-logs.ts

@@ -1,4 +1,5 @@
-import { bytes, op } from '@algorandfoundation/algorand-typescript'
+import type { bytes } from '@algorandfoundation/algorand-typescript'
+import { op } from '@algorandfoundation/algorand-typescript'
 import { ABI_RETURN_VALUE_LOG_PREFIX } from './constants'
 import { asNumber } from './util'