Skip to content

Commit 63458e9

Browse files
committed
Merge remote-tracking branch 'origin/master'
2 parents 7c28cd0 + 8ee8681 commit 63458e9

File tree

3 files changed

+20
-23
lines changed

3 files changed

+20
-23
lines changed

app/controllers/articles_controller.rb

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ class ArticlesController < ApplicationController
99
include WatchersHelper
1010

1111
before_filter :find_project_by_project_id, :authorize
12-
before_filter :get_article, :only => [:add_attachment, :show, :edit, :update, :add_comment, :destroy, :destroy_comment, :diff, :revert, :version]
12+
before_filter :get_article, :except => [:index, :new, :create, :preview, :comment, :tagged, :rate]
1313

1414
rescue_from ActionView::MissingTemplate, :with => :force_404
1515
rescue_from ActiveRecord::RecordNotFound, :with => :force_404
@@ -53,7 +53,7 @@ def create
5353
@article = KbArticle.new(params[:article])
5454
@article.category_id = params[:category_id]
5555
@article.author_id = User.current.id
56-
@article.project_id=KbCategory.find(params[:category_id]).project_id
56+
@article.project_id = KbCategory.find(params[:category_id]).project_id
5757
@categories = @project.categories.find(:all)
5858
# don't keep previous comment
5959
@article.version_comments = params[:article][:version_comments]
@@ -116,14 +116,14 @@ def add_comment
116116
show
117117
render :action => 'show'
118118
end
119-
end
119+
end
120120
end
121121

122122
def destroy_comment
123123
@article.without_locking do
124124
@article.comments.find(params[:comment_id]).destroy
125125
redirect_to :action => 'show', :id => @article, :project_id => @project
126-
end
126+
end
127127
end
128128

129129
def destroy
@@ -140,13 +140,10 @@ def add_attachment
140140

141141
def tagged
142142
@tag = params[:id]
143-
my_direction = params[:direction]
144-
my_sort = params[:sort]
145-
if my_sort && my_direction
146-
my_order = "#{my_sort} #{my_direction}"
147-
@list = @project.articles.order(my_order).tagged_with(@tag)
143+
@list = if params[:sort] && params[:direction]
144+
@project.articles.order("#{params[:sort]} #{params[:direction]}").tagged_with(@tag)
148145
else
149-
@list = @project.articles.tagged_with(@tag)
146+
@project.articles.tagged_with(@tag)
150147
end
151148
end
152149

app/views/articles/index.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@
99
</div>
1010

1111
<% if @project.categories.count == 0 %>
12-
</br>
12+
<h2><%= l(:knowledgebase_title) %></h2>
1313
<p class="nodata"><%= l(:message_no_categories) %></p>
1414

1515
<% elsif @project.articles.count == 0 %>
16-
</br>
16+
<h2><%= l(:knowledgebase_title) %></h2>
1717
<p class="nodata"><%= l(:message_no_articles) %></p>
1818

1919
<% else %>

config/locales/ja.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -57,32 +57,32 @@ ja:
5757
label_title: 件名
5858
label_title_articles: 記事
5959
label_title_category: カテゴリ
60-
label_updated_who: "Updated by %{updater} %{age} ago"
60+
label_updated_who: "%{updater}によって%{age}に更新"
6161
message_no_articles: ナレッジベースに追加された記事はありません.早速作りましょう!
6262
message_no_categories: 定義されたカテゴリがありません.新しいカテゴリを作成するにはログインする必要があります.
6363
message_no_permissions: 記事やカテゴリの閲覧権限がありません.管理者にお問い合わせください.
64-
message_summary_count_not_available: "Summary Count Not Available!"
64+
message_summary_count_not_available: サマリーの集計が有効ではありません!
6565
permission_comment_and_rate_articles: 記事のコメントとレーティング
6666
permission_create_article_categories: 記事のカテゴリ追加
6767
permission_create_articles: 記事の追加
6868
permission_edit_articles: 記事の編集
6969
permission_manage_article_categories: 記事のカテゴリ管理
70-
permission_manage_article_history: "manage article history"
70+
permission_manage_article_history: 記事の履歴管理
7171
permission_manage_articles: 記事の管理
7272
permission_manage_articles_comments: 記事のコメント管理
73-
permission_view_article_history: "view article history"
73+
permission_view_article_history: 記事履歴の閲覧
7474
permission_view_articles: 記事の閲覧
75-
permission_view_kb_articles: "View articles"
76-
permission_view_most_popular_articles: "view most popular articles"
77-
permission_view_recent_articles: "View recent articles"
78-
permission_view_top_rated_articles: "view top rated articles"
79-
permission_watch_articles: "Watch articles"
80-
permission_watch_categories: "Watch categories"
75+
permission_view_kb_articles: 記事の閲覧
76+
permission_view_most_popular_articles: 人気記事の閲覧
77+
permission_view_recent_articles: 最近の記事閲覧
78+
permission_view_top_rated_articles: トップレート記事の閲覧
79+
permission_watch_articles: 記事のウォッチ
80+
permission_watch_categories: カテゴリのウォッチ
8181
project_module_knowledgebase: Knowledgebase
8282
show_category_totals: ツリーの全てのカテゴリを表示する
8383
summary_item_limit: ナレッジベースに表示する記事数
8484
text_confirm_versions_delete: このドキュメントの新しいバージョンが存在する場合、記事は逆戻りして削除されます.よろしいですか?
85-
text_current_version: Current
85+
text_current_version: 現在のバージョン
8686
title_add_comment: コメントを追加
8787
title_article_rating: 評価レート
8888
title_browse_by_category: カテゴリ別一覧

0 commit comments

Comments
 (0)