Skip to content

Conversation

samyilias
Copy link
Contributor

@samyilias samyilias commented May 24, 2021

feature-toggle-jsx README example import and usage of FeaturesProvider
was wrong, this commit will change FeatureProvider to FeaturesProvider

Closes: #648

feature-toggle-jsx README example import and usage of FeaturesProvider
was wrong, this commit will change FeatureProvider to FeaturesProvider

BREAKING CHANGE: 🧨 none

✅ Closes: agoda-com#648
@samyilias
Copy link
Contributor Author

samyilias commented Jun 7, 2021

@ches @kanokgan I need approval for CI :)

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #649 (bb0a5b1) into master (dbf36de) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #649   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          281       303   +22     
  Branches        63        71    +8     
=========================================
+ Hits           281       303   +22     
Impacted Files Coverage Δ
packages/ab-test-jsx/src/withABTest/withABTest.tsx 100.00% <ø> (ø)
...ckages/ab-test-jsx/src/withABTests/withABTests.tsx 100.00% <ø> (ø)
...fast-number-formatter/src/numberFormatter/index.ts 100.00% <ø> (ø)
...feature-toggle-jsx/src/withFeature/withFeature.tsx 100.00% <ø> (ø)
...e-toggle-jsx/src/withoutFeature/withoutFeature.tsx 100.00% <ø> (ø)
packages/i18n-jsx/src/useI18n/useI18n.tsx 100.00% <ø> (ø)
.../some-handy-hooks/src/useCountdown/useCountdown.ts 100.00% <ø> (ø)
...sx/src/withABTestsProvider/withABTestsProvider.tsx 100.00% <100.00%> (ø)
...ry-jsx/src/withErrorBoundary/withErrorBoundary.tsx 100.00% <100.00%> (ø)
.../src/withFeaturesProvider/withFeaturesProvider.tsx 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0060d...bb0a5b1. Read the comment docs.

@matmalkowski matmalkowski merged commit bb7a408 into agoda-com:master Jun 9, 2021
@matmalkowski
Copy link
Member

🎉 This PR is included in version feature-toggle-jsx-v4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature-toggle-jsx] README has wrong import example for FeaturesProvider
2 participants