Skip to content

Commit dab9ae2

Browse files
committed
[Java, C++] Tidy up.
Removes extraneous space in Java output when access order checks are disabled. Removes unnecessary access modifiers in C++ when access order checks are disabled.
1 parent cef3e1f commit dab9ae2

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/cpp/CppGenerator.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -767,10 +767,13 @@ private static void generateGroupClassHeader(
767767
}
768768

769769

770-
sb.append("\n").append(indent).append("private:");
771-
generateAccessOrderListenerMethodForNextGroupElement(sb, accessOrderModel, indent, groupToken);
772-
generateAccessOrderListenerMethodForResetGroupCount(sb, accessOrderModel, indent, groupToken);
773-
sb.append("\n").append(indent).append("public:");
770+
if (null != accessOrderModel)
771+
{
772+
sb.append("\n").append(indent).append("private:");
773+
generateAccessOrderListenerMethodForNextGroupElement(sb, accessOrderModel, indent, groupToken);
774+
generateAccessOrderListenerMethodForResetGroupCount(sb, accessOrderModel, indent, groupToken);
775+
sb.append("\n").append(indent).append("public:");
776+
}
774777

775778
final CharSequence onNextAccessOrderCall = null == accessOrderModel ? "" :
776779
generateAccessOrderListenerCall(accessOrderModel, indent + TWO_INDENT, "onNextElementAccessed");

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/java/JavaGenerator.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -654,7 +654,7 @@ private static void generateAccessOrderListenerMethodForNextGroupElement(
654654
selectLastElementInGroup);
655655

656656
sb.append(indent).append(" }\n")
657-
.append(indent).append("}\n");
657+
.append(indent).append("}\n\n");
658658
}
659659

660660
private static void generateAccessOrderListenerMethodForResetGroupCount(
@@ -681,7 +681,7 @@ private static void generateAccessOrderListenerMethodForResetGroupCount(
681681
accessOrderModel,
682682
resetCountToIndex);
683683

684-
sb.append(indent).append("}\n");
684+
sb.append(indent).append("}\n\n");
685685
}
686686

687687
private static void generateAccessOrderListenerMethodForVarDataLength(
@@ -964,8 +964,7 @@ private void generateGroupDecoderClassHeader(
964964

965965
generateAccessOrderListenerMethodForNextGroupElement(sb, accessOrderModel, indent + " ", groupToken);
966966

967-
sb.append("\n")
968-
.append(indent).append(" public ").append(className).append(" next()\n")
967+
sb.append(indent).append(" public ").append(className).append(" next()\n")
969968
.append(indent).append(" {\n")
970969
.append(indent).append(" if (index >= count)\n")
971970
.append(indent).append(" {\n")
@@ -1105,8 +1104,7 @@ private void generateGroupEncoderClassHeader(
11051104
generateAccessOrderListenerMethodForNextGroupElement(sb, accessOrderModel, ind + " ", groupToken);
11061105
generateAccessOrderListenerMethodForResetGroupCount(sb, accessOrderModel, ind + " ", groupToken);
11071106

1108-
sb.append("\n")
1109-
.append(ind).append(" public ").append(encoderName(groupName)).append(" next()\n")
1107+
sb.append(ind).append(" public ").append(encoderName(groupName)).append(" next()\n")
11101108
.append(ind).append(" {\n")
11111109
.append(generateAccessOrderListenerCall(accessOrderModel, ind + " ", "onNextElementAccessed"))
11121110
.append(ind).append(" if (index >= count)\n")
@@ -1123,8 +1121,7 @@ private void generateGroupEncoderClassHeader(
11231121
final String resetCountPut = generatePut(
11241122
numInGroupTypeCast, countOffset, numInGroupValue, byteOrderString(numInGroupToken.encoding()));
11251123

1126-
sb.append("\n")
1127-
.append(ind).append(" public int resetCountToIndex()\n")
1124+
sb.append(ind).append(" public int resetCountToIndex()\n")
11281125
.append(ind).append(" {\n")
11291126
.append(generateAccessOrderListenerCall(accessOrderModel, ind + " ", "onResetCountToIndex"))
11301127
.append(ind).append(" count = index;\n")

0 commit comments

Comments
 (0)