[Java, C++, C#] Disable access order checking feature by default.

We can deliver this new feature (and the C++ changes around copy
constructors and copy assignment operators) without breaking any
existing consumers by disabling the new code generation by default.

Once released, and we've started to get feedback, we can decide whether
we want to change the default and encourage our users to make use of the
new feature.

Author: ZachBray

build.gradle

@@ -279,7 +279,8 @@ project(':sbe-tool') {
                 'sbe.output.dir': generatedDir,
                 'sbe.target.language': 'Java',
                 'sbe.validation.stop.on.error': 'true',
-                'sbe.validation.xsd': validationXsdPath)
+                'sbe.validation.xsd': validationXsdPath,
+                'sbe.generate.access.order.checks': 'true')
         args = ['src/test/resources/json-printer-test-schema.xml',
                 'src/test/resources/composite-elements-schema.xml',
                 'src/test/resources/field-order-check-schema.xml']
@@ -732,7 +733,8 @@ tasks.register('generateCSharpCodecsTests', JavaExec) {
             'sbe.output.dir': 'csharp/sbe-generated',
             'sbe.target.language': 'uk.co.real_logic.sbe.generation.csharp.CSharp',
             'sbe.xinclude.aware': 'true',
-            'sbe.validation.xsd': validationXsdPath)
+            'sbe.validation.xsd': validationXsdPath,
+            'sbe.generate.access.order.checks': 'true')
     args = ['sbe-tool/src/test/resources/FixBinary.xml',
             'sbe-tool/src/test/resources/issue435.xml',
             'sbe-tool/src/test/resources/issue483.xml',
@@ -756,7 +758,8 @@ tasks.register('generateJavaIrCodecs', JavaExec) {
     systemProperties(
             'sbe.output.dir': 'sbe-tool/src/main/java',
             'sbe.target.language': 'Java',
-            'sbe.validation.xsd': validationXsdPath)
+            'sbe.validation.xsd': validationXsdPath,
+            'sbe.generate.access.order.checks': 'true')
     args = ['sbe-tool/src/main/resources/sbe-ir.xml']
 }
 
@@ -766,7 +769,8 @@ tasks.register('generateCppIrCodecs', JavaExec) {
     systemProperties(
             'sbe.output.dir': 'sbe-tool/src/main/cpp',
             'sbe.target.language': 'cpp',
-            'sbe.validation.xsd': validationXsdPath)
+            'sbe.validation.xsd': validationXsdPath,
+            'sbe.generate.access.order.checks': 'true')
     args = ['sbe-tool/src/main/resources/sbe-ir.xml']
 }
 

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/common/AccessOrderModel.java

@@ -41,7 +41,7 @@
 public final class AccessOrderModel
 {
     private static final boolean GENERATE_ACCESS_ORDER_CHECKS = Boolean.parseBoolean(
-        System.getProperty("sbe.generate.access.order.checks", "true"));
+        System.getProperty("sbe.generate.access.order.checks", "false"));
     private final Map<Token, String> groupPathsByField = new HashMap<>();
     private final Set<Token> topLevelBlockFields = new HashSet<>();
     private final CodecInteraction.HashConsingFactory interactionFactory =

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/cpp/CppGenerator.java

@@ -47,7 +47,7 @@
 public class CppGenerator implements CodeGenerator
 {
     private static final boolean DISABLE_IMPLICIT_COPYING = Boolean.parseBoolean(
-        System.getProperty("sbe.disable.implicit.copying", "true"));
+        System.getProperty("sbe.cpp.disable.implicit.copying", "false"));
     private static final String BASE_INDENT = "";
     private static final String INDENT = "    ";
     private static final String TWO_INDENT = INDENT + INDENT;

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/csharp/CSharpGenerator.java

@@ -2552,12 +2552,15 @@ private CharSequence generateDisplay(
         append(sb, TWO_INDENT, "    }");
         sb.append('\n');
         append(sb, TWO_INDENT, "    int originalLimit = this.Limit;");
-        sb.append("#if ENABLE_ACCESS_ORDER_CHECKS\n");
-        append(sb, TWO_INDENT, "    CodecState originalState = _codecState;");
-        sb.append(THREE_INDENT).append("_codecState = ")
-            .append(qualifiedStateCase(accessOrderModel.notWrappedState())).append(";\n");
-        append(sb, TWO_INDENT, "    OnWrapForDecode(_actingVersion);");
-        sb.append("#endif\n");
+        if (null != accessOrderModel)
+        {
+            sb.append("#if ENABLE_ACCESS_ORDER_CHECKS\n");
+            append(sb, TWO_INDENT, "    CodecState originalState = _codecState;");
+            sb.append(THREE_INDENT).append("_codecState = ")
+                .append(qualifiedStateCase(accessOrderModel.notWrappedState())).append(";\n");
+            append(sb, TWO_INDENT, "    OnWrapForDecode(_actingVersion);");
+            sb.append("#endif\n");
+        }
         append(sb, TWO_INDENT, "    this.Limit = _offset + _actingBlockLength;");
         append(sb, TWO_INDENT, "    builder.Append(\"[" + name + "](sbeTemplateId=\");");
         append(sb, TWO_INDENT, "    builder.Append(" + name + ".TemplateId);");
@@ -2581,9 +2584,12 @@ private CharSequence generateDisplay(
         sb.append('\n');
         appendDisplay(sb, tokens, groups, varData, THREE_INDENT);
         sb.append('\n');
-        sb.append("#if ENABLE_ACCESS_ORDER_CHECKS\n");
-        append(sb, TWO_INDENT, "    _codecState = originalState;");
-        sb.append("#endif\n");
+        if (null != accessOrderModel)
+        {
+            sb.append("#if ENABLE_ACCESS_ORDER_CHECKS\n");
+            append(sb, TWO_INDENT, "    _codecState = originalState;");
+            sb.append("#endif\n");
+        }
         append(sb, TWO_INDENT, "    this.Limit = originalLimit;");
         sb.append('\n');
         append(sb, TWO_INDENT, "}");

sbe-tool/src/test/cpp/CMakeLists.txt

@@ -63,6 +63,8 @@ add_custom_command(
             -Dsbe.output.dir=${CXX_CODEC_TARGET_DIR}
             -Dsbe.generate.ir="true"
             -Dsbe.target.language="cpp"
+            -Dsbe.generate.access.order.checks="true"
+            -Dsbe.cpp.disable.implicit.copying="true"
             -jar ${SBE_JAR}
             ${CODE_GENERATION_SCHEMA}
             ${COMPOSITE_OFFSETS_SCHEMA}