Add assertions and cleanup #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denizevrenci
force-pushed
the
issue_579
branch
2 times, most recently
from
3f23e19 to
5704bc2
Compare
mjpt777
reviewed
Dec 3, 2018
| } | ||
|
|
||
| inline static void initializeTailWithTermId(AtomicBuffer& logMetaDataBuffer, int partitionIndex, std::int32_t termId) | ||
| inline void initializeTailWithTermId(AtomicBuffer& logMetaDataBuffer, int partitionIndex, std::int32_t termId) |
There was a problem hiding this comment.
Why remove the static declaration from methods? Would this not be a breaking API change?
There was a problem hiding this comment.
It may break the ABI in case someone wants to compile object files with the new header and link with the client library that was compiled with the old headers. With a simple test case, I confirmed that two object files still link if one of them is inline static and the other is only inline. The advantage is that the resulting binary is smaller as the linker is now free to eliminate repeating inline symbols as they are not internally linked.
denizevrenci
force-pushed
the
issue_579
branch
2 times, most recently
from
e47382d to
418fbcf
Compare
|
Can this be brought up to date? Right now it has conflicts. |
Only inline specifier is enough for functions in namespace scope in a header for avoiding multiple definitions.
const qualifier implies static in namespace scope.
denizevrenci
force-pushed
the
issue_579
branch
from
418fbcf to
4d5979c
Compare
|
Rebased on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #579