Cannot change focal element on notify close

### Subject of the issue
When opening a notify, it captures the `document.activeElement` to return there upon closing. There is no easy way to change the element that should be focused after the notify closes. 

This feature was introduced in 2018 in [this commit](https://github.com/adaptlearning/adapt-contrib-core/commit/244af2a2ff56a840cf463e982f1e2d6b5f4d8eac#diff-d5d956ed97fb3ba2c05b53c661af8cc71a1d68646cdb4be37d58e3ecbcde4565R141), with the following lines in play:

https://github.com/adaptlearning/adapt-contrib-core/blob/244af2a2ff56a840cf463e982f1e2d6b5f4d8eac/js/views/notifyView.js#L141
https://github.com/adaptlearning/adapt-contrib-core/blob/244af2a2ff56a840cf463e982f1e2d6b5f4d8eac/js/views/notifyView.js#L228
https://github.com/adaptlearning/adapt-contrib-core/blob/73ef2176dae0750f99ab6e3fb5578ef8dfc85d69/js/popupManager.js#L14-L22

And can be seen in today's code at these lines:

https://github.com/adaptlearning/adapt-contrib-core/blob/e7fe240d9ef552d0f8229bd0ad5f4134d375c43a/js/views/notifyPopupView.js#L130
https://github.com/adaptlearning/adapt-contrib-core/blob/e7fe240d9ef552d0f8229bd0ad5f4134d375c43a/js/views/notifyPopupView.js#L206
https://github.com/adaptlearning/adapt-contrib-core/blob/e7fe240d9ef552d0f8229bd0ad5f4134d375c43a/js/a11y/popup.js#L152-L158

It would be ideal if we could use the `a11y.setPopupCloseTo` for the notify:

https://github.com/adaptlearning/adapt-contrib-core/blob/e7fe240d9ef552d0f8229bd0ad5f4134d375c43a/js/a11y.js#L909-L918
https://github.com/adaptlearning/adapt-contrib-core/blob/e7fe240d9ef552d0f8229bd0ad5f4134d375c43a/js/a11y/popup.js#L230-L233

	Adapt.on('popup:closed', function($target) {

	//restore tab indexes
	var $launchedElement = $.a11y_popdown();
	var $activeElement = $target \|\| $launchedElement;

	if ($activeElement) {
	return $activeElement.focusOrNext();
	}

	closed($focusElement, silent) {
	const $previousFocusElement = this._removeLastPopupLayer();
	$focusElement = $focusElement \|\| $previousFocusElement \|\| $('body');
	if (!silent) {
	Adapt.trigger('popup:closed', $focusElement, true);
	}
	this.a11y.focusFirst($($focusElement), { preventScroll: true });

	/**
	* When a popup is open, this function makes it possible to swap the element
	* that should receive focus on popup close.
	*
	* @param {Object} $focusElement Set a new element to focus on.
	* @returns {Object} Returns previously set focus element.
	*/
	setPopupCloseTo($focusElement) {
	return this._popup.setCloseTo($focusElement);
	}

	setCloseTo($focusElement) {
	const $original = this._focusStack.pop();
	this._focusStack.push($focusElement);
	return $original;

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cannot change focal element on notify close #676

Subject of the issue

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Cannot change focal element on notify close #676

Description

Subject of the issue

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions