fix: Make alias and rename safe (#31)

Signed-off-by: Steve Hipwell <[email protected]>

Author: stevehipwell

CHANGELOG.md

@@ -22,6 +22,10 @@
 - Update _action-stars/generic-workflows_ from `0.7.0` to `0.7.1`. ([#29](https://github.com/action-stars/install-tool-from-github-release/pull/29)) _@dependabot_
 - Update _action-stars/generic-workflows_ from `0.7.1` to `0.7.2`. ([#30](https://github.com/action-stars/install-tool-from-github-release/pull/30)) _@dependabot_
 
+### Fixed
+
+- Fix `rename` & `alias` inputs to use the installation directory. ([#31](https://github.com/action-stars/install-tool-from-github-release/pull/31)) _@stevehipwell_
+
 ## [v0.2.5] - 2025-05-12
 
 ### Changed

action.yml

@@ -121,6 +121,7 @@ runs:
 
     - name: Install tool
       uses: pbrisbin/setup-tool-action@87ea9f382eb6b0357d78908ac3b61cc4d8f87ef3 # v2.2.2
+      id: install
       with:
         github-token: ${{ inputs.github_token }}
         name: ${{ inputs.name || inputs.repository }}
@@ -142,30 +143,44 @@ runs:
     - name: Rename
       if: inputs.rename
       shell: bash
+      env:
+        INPUT_DIRECTORY: ${{ steps.install.outputs.directory }}
+        INPUT_RENAME: ${{ inputs.rename }}
       run: |
         set -euo pipefail
 
-        input="${{ inputs.rename }}"
-        before="${input%=*}"
-        after="${input#*=}"
+        before="${INPUT_RENAME%=*}"
+        after="${INPUT_RENAME#*=}"
 
-        before_path="$(which "${before}")"
-        after_path="$(dirname "${before_path}")/${after}"
+        before_path="${INPUT_DIRECTORY}/${before}"
+        after_path="${INPUT_DIRECTORY}/${after}"
+
+        if [[ ! -f "${before_path}" ]]; then
+          echo "File does not exist: ${before_path}"
+          exit 1
+        fi
 
         mv -f "${before_path}" "${after_path}"
 
     - name: Alias
       if: inputs.alias
       shell: bash
+      env:
+        INPUT_DIRECTORY: ${{ steps.install.outputs.directory }}
+        INPUT_ALIAS: ${{ inputs.alias }}
       run: |
         set -euo pipefail
 
-        input="${{ inputs.alias }}"
-        target="${input%=*}"
-        alias="${input#*=}"
+        target="${INPUT_ALIAS%=*}"
+        alias="${INPUT_ALIAS#*=}"
 
-        target_path="$(which "${target}")"
-        alias_path="$(dirname "${target_path}")/${alias}"
+        target_path="${INPUT_DIRECTORY}/${target}"
+        alias_path="${INPUT_DIRECTORY}/${alias}"
+
+        if [[ ! -f "${target_path}" ]]; then
+          echo "Target file does not exist: ${target_path}"
+          exit 1
+        fi
 
         ln -s "${target_path}" "${alias_path}"