Skip to content

Simplified HasAbout trait #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Simplified HasAbout trait #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions src/Concerns/HasAbout.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,12 @@
namespace DragonCode\LaravelDeployOperations\Concerns;

use Composer\InstalledVersions;
use DragonCode\Support\Facades\Helpers\Arr;
use DragonCode\Support\Facades\Helpers\Str;
use Illuminate\Foundation\Console\AboutCommand;

trait HasAbout
{
protected string $composer = __DIR__ . '/../../composer.json';

protected ?string $packageName = null;
protected string $packageName = 'dragon-code/laravel-deploy-operations';

protected function registerAbout(): void
{
Expand All @@ -24,7 +21,7 @@ protected function registerAbout(): void

protected function getPackageName(): string
{
return Str::of($this->loadPackageName())
return Str::of($this->packageName)
->after('/')
->snake()
->replace('_', ' ')
Expand All @@ -34,11 +31,6 @@ protected function getPackageName(): string

protected function getPackageVersion(): string
{
return InstalledVersions::getPrettyVersion($this->loadPackageName());
}

protected function loadPackageName(): string
{
return $this->packageName ??= Arr::ofFile($this->composer)->get('name');
return InstalledVersions::getPrettyVersion($this->packageName);
}
}