Skip to content

Commit e9351dd

Browse files
Hotfix/optim (#262)
1 parent c44d8d8 commit e9351dd

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

docs/src/developer/optimizer.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ SemOptimizer{:Name}(args...; kwargs...) = SemOptimizerName(args...; kwargs...)
1616

1717
SemOptimizerName(;
1818
algorithm = LBFGS(),
19-
options = Optim.Options(; f_tol = 1e-10, x_tol = 1.5e-8),
19+
options = Optim.Options(; f_reltol = 1e-10, x_abstol = 1.5e-8),
2020
kwargs...,
2121
) = SemOptimizerName(algorithm, options)
2222

@@ -40,7 +40,7 @@ Similarly, `SemOptimizer{:Name}(args...; kwargs...) = SemOptimizerName(args...;
4040
```julia
4141
SemOptimizerName(;
4242
algorithm = LBFGS(),
43-
options = Optim.Options(; f_tol = 1e-10, x_tol = 1.5e-8),
43+
options = Optim.Options(; f_reltol = 1e-10, x_abstol = 1.5e-8),
4444
kwargs...,
4545
) = SemOptimizerName(algorithm, options)
4646
```

src/optimizer/optim.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Connects to `Optim.jl` as the optimization backend.
1212
1313
SemOptimizerOptim(;
1414
algorithm = LBFGS(),
15-
options = Optim.Options(;f_tol = 1e-10, x_tol = 1.5e-8),
15+
options = Optim.Options(;f_reltol = 1e-10, x_abstol = 1.5e-8),
1616
kwargs...)
1717
1818
# Arguments
@@ -67,7 +67,7 @@ SemOptimizer{:Optim}(args...; kwargs...) = SemOptimizerOptim(args...; kwargs...)
6767

6868
SemOptimizerOptim(;
6969
algorithm = LBFGS(),
70-
options = Optim.Options(; f_tol = 1e-10, x_tol = 1.5e-8),
70+
options = Optim.Options(;f_reltol = 1e-10, x_abstol = 1.5e-8),
7171
kwargs...,
7272
) = SemOptimizerOptim(algorithm, options)
7373

test/examples/recover_parameters/recover_parameters_twofact.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ objective!(model_ml, true_val)
7070

7171
optimizer = SemOptimizerOptim(
7272
BFGS(; linesearch = BackTracking(order = 3), alphaguess = InitialHagerZhang()),# m = 100),
73-
Optim.Options(; f_tol = 1e-10, x_tol = 1.5e-8),
73+
Optim.Options(; f_reltol = 1e-10, x_abstol = 1.5e-8),
7474
)
7575

7676
solution_ml = fit(optimizer, model_ml)

0 commit comments

Comments
 (0)