Skip to content

SLVS-2500 Respect NET repackaging #6390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 28, 2025
Merged

SLVS-2500 Respect NET repackaging #6390

merged 8 commits into from
Aug 28, 2025

Conversation

@gabriela-trutan-sonarsource
Copy link
Contributor

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource commented Aug 28, 2025 •
edited by atlassian bot
Loading

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource marked this pull request as ready for review August 28, 2025 12:50
georgii-borovinskikh-sonarsource
georgii-borovinskikh-sonarsource approved these changes Aug 28, 2025
View reviewed changes
src/Integration.Vsix/EmbeddedAnalyzers/EmbeddedDotnetAnalyzersLocator.cs Outdated
{
var languageToDllsMap = new Dictionary<RoslynLanguage, List<string>>
{
{ RoslynLanguage.CSharp, GetAnalyzerFullPathsByLanguage(RoslynLanguage.CSharp, analyzerInfoDto.ShouldUseCsharpEnterprise) },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded mapping :-/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do need a mapping, because of the bool values. Either I do it here, either I do it in another model, I still need to map each language to the corresponding bool

@sonarqubecloud
Copy link

🤖 Pull Request summary

Updates SLOOP version to 10.29.0 and refactors analyzer configuration to support enterprise analyzer selection.

• Version bump: SLOOP embedded version updated from 10.28.0 to 10.29.0
• API consolidation: Merged GetBasicAnalyzerFullPathsByLanguage() and GetEnterpriseAnalyzerFullPathsByLanguage() into single GetAnalyzerFullPathsByLanguage() method
• Enterprise analyzer control: Added AnalyzerInfoDto parameter to control C# and VB.NET enterprise analyzer inclusion per language
• Request model update: Extended AnalysisRequest to include AnalyzerInfo field for analyzer selection
• Dependency cleanup: Removed ILanguageProvider dependency from analyzer locator

Focus areas for review:

  • Verify the analyzer selection logic correctly filters enterprise analyzers based on AnalyzerInfoDto flags
  • Ensure backward compatibility with the consolidated analyzer locator interface

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource merged commit b74c888 into feature/sqvs-roslyn-plugin Aug 28, 2025
3 checks passed
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource deleted the gt/dotnet-repackaging branch August 28, 2025 15:15
georgii-borovinskikh-sonarsource pushed a commit that referenced this pull request Sep 10, 2025
@gabriela-trutan-sonarsource @georgii-borovinskikh-sonarsource
SLVS-2500 Respect NET repackaging (#6390)
148cebf
gabriela-trutan-sonarsource added a commit that referenced this pull request Sep 17, 2025
@gabriela-trutan-sonarsource
SLVS-2500 Respect NET repackaging (#6390)
21d67c3
georgii-borovinskikh-sonarsource pushed a commit that referenced this pull request Sep 30, 2025
@gabriela-trutan-sonarsource @georgii-borovinskikh-sonarsource
SLVS-2500 Respect NET repackaging (#6390)
1008971
georgii-borovinskikh-sonarsource pushed a commit that referenced this pull request Oct 14, 2025
@gabriela-trutan-sonarsource @georgii-borovinskikh-sonarsource
SLVS-2500 Respect NET repackaging (#6390)
c7ee9f8
georgii-borovinskikh-sonarsource pushed a commit that referenced this pull request Oct 30, 2025
@gabriela-trutan-sonarsource @georgii-borovinskikh-sonarsource
SLVS-2500 Respect NET repackaging (#6390)
3267da8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gabriela-trutan-sonarsource @georgii-borovinskikh-sonarsource