Skip to content

Commit b85e852

Browse files
committed
[bazel] Remove empty globs
In Bazel 8, the default is to disallow empty globs. Rather than make more changes as we update, instead we'll flip the flag now and fix up any issues. This will make the Bazel 8 update simpler.
1 parent 29e858f commit b85e852

File tree

9 files changed

+5
-59
lines changed

9 files changed

+5
-59
lines changed

.bazelrc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,10 @@ try-import %workspace%/.bazelrc.windows.local
88
# https://github.com/bazelbuild/bazel/issues/20369
99
# https://github.com/bazelbuild/bazel/issues/21491
1010

11-
common --enable_bzlmod --lockfile_mode=off
11+
common --lockfile_mode=off
12+
13+
# Prepare for Bazel 8. This becomes the default in 8.0.0
14+
common --incompatible_disallow_empty_glob
1215

1316
# Ensure Windows support is accurate.
1417

dotnet/src/support/BUILD.bazel

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ csharp_library(
3131
"*.cs",
3232
"Events/*.cs",
3333
"Extensions/*.cs",
34-
"PageObjects/**/*.cs",
3534
"UI/*.cs",
3635
]) + [":assembly-info"],
3736
out = "WebDriver.Support",
@@ -71,7 +70,6 @@ csharp_library(
7170
"*.cs",
7271
"Events/*.cs",
7372
"Extensions/*.cs",
74-
"PageObjects/**/*.cs",
7573
"UI/*.cs",
7674
]) + [":assembly-info"],
7775
out = "WebDriver.Support.StrongNamed",

dotnet/test/support/Events/BUILD.bazel

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,7 @@ dotnet_nunit_test_suite(
2222
name = "LargeTests",
2323
size = "large",
2424
srcs = glob(
25-
[
26-
"**/*Test.cs",
27-
"**/*Tests.cs",
28-
],
25+
["*Test.cs"],
2926
exclude = SMALL_TESTS,
3027
) + [
3128
"//dotnet/test/common:assembly-fixtures",

java/src/org/openqa/selenium/grid/session/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ java_library(
55
name = "session",
66
srcs = glob([
77
"*.java",
8-
"remote/*.java",
98
]),
109
visibility = [
1110
"//java/src/org/openqa/selenium/grid:__subpackages__",
Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +0,0 @@
1-
load("@rules_jvm_external//:defs.bzl", "artifact")
2-
load("//java:defs.bzl", "JUNIT5_DEPS", "java_test_suite")
3-
load("//java:version.bzl", "TOOLS_JAVA_VERSION")
4-
5-
java_test_suite(
6-
name = "SmallTests",
7-
size = "small",
8-
srcs = glob(["*Test.java"]),
9-
javacopts = [
10-
"--release",
11-
TOOLS_JAVA_VERSION,
12-
],
13-
deps = [
14-
"//java/src/org/openqa/selenium/events",
15-
"//java/src/org/openqa/selenium/events/local",
16-
"//java/src/org/openqa/selenium/grid/data",
17-
"//java/src/org/openqa/selenium/grid/security",
18-
"//java/src/org/openqa/selenium/grid/sessionqueue",
19-
"//java/src/org/openqa/selenium/grid/sessionqueue/local",
20-
"//java/src/org/openqa/selenium/grid/sessionqueue/remote",
21-
"//java/src/org/openqa/selenium/json",
22-
"//java/src/org/openqa/selenium/remote",
23-
"//java/src/org/openqa/selenium/support",
24-
"//java/test/org/openqa/selenium/grid/testing",
25-
"//java/test/org/openqa/selenium/remote/tracing:tracing-support",
26-
artifact("org.junit.jupiter:junit-jupiter-api"),
27-
artifact("io.opentelemetry:opentelemetry-api"),
28-
artifact("org.assertj:assertj-core"),
29-
artifact("com.google.guava:guava"),
30-
] + JUNIT5_DEPS,
31-
)

java/test/org/openqa/selenium/remote/codec/jwp/BUILD.bazel

Lines changed: 0 additions & 17 deletions
This file was deleted.

javascript/grid-ui/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ js_library(
2727

2828
SRCS = glob(
2929
[
30-
"public/**/*",
3130
"src/**/*",
3231
],
3332
exclude = [

javascript/node/selenium-webdriver/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ js_library(
3232
"http/*.js",
3333
"io/*.js",
3434
"lib/*.js",
35-
"lib/atoms/bidi-mutation-listener.js",
3635
"lib/fedcm/*.js",
3736
"net/*.js",
3837
"remote/*.js",

rb/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@ rb_binary(
179179

180180
rb_test(
181181
name = "lint",
182-
srcs = glob(["**/*.rb"]),
183182
args = [
184183
"--autocorrect",
185184
"--config=rb/.rubocop.yml",

0 commit comments

Comments
 (0)