Skip to content

Commit 7f7bc89

Browse files
authored
fix: double icons in display name column on package systems table (#1183)
* fix: double icons in display name column on package systems table * chore: remove tags column defs from package systems table
1 parent bd177e8 commit 7f7bc89

File tree

3 files changed

+3
-16
lines changed

3 files changed

+3
-16
lines changed

src/SmartComponents/Systems/SystemListAssets.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ describe('SystemListAssets.js', () => {
2323
});
2424

2525
it('Should call createUpgradableColumn on Status renderFunc with correct params', () => {
26-
packageSystemsColumns[6].renderFunc('testValue');
26+
packageSystemsColumns[4].renderFunc('testValue');
2727
expect(createUpgradableColumn).toHaveBeenCalledWith('testValue');
2828
});
2929

src/SmartComponents/Systems/SystemsListAssets.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -95,19 +95,6 @@ export const advisorySystemsColumns = () => [
9595
];
9696

9797
export const packageSystemsColumns = [
98-
{
99-
key: 'display_name',
100-
title: 'Name',
101-
composed: ['facts.os_release', 'display_name'],
102-
props: {
103-
width: 40
104-
}
105-
},
106-
{
107-
key: 'tags',
108-
title: 'Tags',
109-
props: { width: 10, isStatic: true }
110-
},
11198
{
11299
key: 'os',
113100
title: 'OS',

src/Utilities/SystemHelpers.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ describe('createSystemsSortBy,', () => {
2626

2727
it('should translate updated parameter while having last upload', () => {
2828
expect(createSystemsSortBy('updated', 'ASC', true)).toEqual(
29-
'display_name'
29+
'os'
3030
);
3131
expect(createSystemsSortBy('updated', 'DESC', true)).toEqual(
32-
'-display_name'
32+
'-os'
3333
);
3434
});
3535
});

0 commit comments

Comments
 (0)