fix: ROUND, ENCODE_FOR_URI and SECONDS SPARQL functions
#2314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20230325T2326-fix_sparql_functions
branch
from
c834a76 to
97f81f3
Compare
`ROUND` was not correctly rounding negative numbers towards positive infinity, `ENCODE_FOR_URI` incorrectly treated `/` as safe, and `SECONDS` did not include fractional seconds. This change corrects these issues. - Closes <RDFLib#2151>.
aucampia
force-pushed
the
iwana-20230325T2326-fix_sparql_functions
branch
from
97f81f3 to
c7db012
Compare
aucampia
added
review wanted
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
ROUNDwas not correctly rounding negative numbers towards positive infinity,ENCODE_FOR_URIincorrectly treated/as safe, andSECONDSdid not include fractional seconds.This change corrects these issues.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.