Fixed bug in SemanticVersion.Compare #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, that is a silly bug for sure! |
JakeGinnivan
added a commit
that referenced
this pull request
Jun 3, 2014
Fixed bug in SemanticVersion.Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SemanticVersion.CompareTo() function cannot decide if the other SemanticVersion from parameter should go before or after the current instance, it returns -1. This is wrong as the function should return 0 when both instances should be considered as equal.
Before the bug fix, it is also impossible to use OrderBy on enumeration of SemanticVerions with two same versions because it get stuck on the comparision and never finishes. This is probably because the result collection never seems as ordered because on every pass, the equal versions seem to be in wrong order (the second should go before the first).