Skip to content

Commit d14aadf

Browse files
authored
[FIx] CI Approve fix (#4316)
* check approve * fix the bug * update
1 parent 81959c7 commit d14aadf

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

scripts/check_approval.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ WORKER_OR_CONFIG_LIST=(
5959
)
6060

6161
HAS_WORKER_OR_CONFIG_MODIFY=`git diff upstream/$BRANCH --name-only | grep -E $(printf -- "-e %s " "${WORKER_OR_CONFIG_LIST[@]}") || true`
62-
if [ ${HAS_WORKER_OR_CONFIG_MODIFY} ] && [ "${PR_ID}" != "" ]; then
62+
if [ "${HAS_WORKER_OR_CONFIG_MODIFY}" != "" ] && [ "${PR_ID}" != "" ]; then
6363
echo_line1="You must have one FastDeploy RD (gongshaotian(gongshaotian), yuanlehome(liuyuanle)) approval for modifing [$(IFS=', '; echo "${WORKER_OR_CONFIG_LIST[*]}")]."
6464
check_approval "$echo_line1" 1 gongshaotian yuanlehome
6565
fi
@@ -70,7 +70,7 @@ SPECULATIVE_DECODING_LIST=(
7070
)
7171

7272
HAS_SPECULATIVE_DECODING_MODIFY=`git diff upstream/$BRANCH --name-only | grep -E $(printf -- "-e %s " "${SPECULATIVE_DECODING_LIST[@]}") || true`
73-
if [ ${HAS_SPECULATIVE_DECODING_MODIFY} ] && [ "${PR_ID}" != "" ]; then
73+
if [ "${HAS_SPECULATIVE_DECODING_MODIFY}" != "" ] && [ "${PR_ID}" != "" ]; then
7474
echo_line1="You must have one FastDeploy RD (freeliuzc(liuzichang01), Deleter-D(wangyanpeng04)) approval for modifing [$(IFS=', '; echo "${SPECULATIVE_DECODING_LIST[*]}")]."
7575
check_approval "$echo_line1" 1 freeliuzc Deleter-D
7676
fi

0 commit comments

Comments
 (0)