Skip to content

Commit 15e663c

Browse files
schwabecron2
authored andcommitted
Fix incorrect condition for checking password related check
Commit db48cea chagned logic to move logic from a variable and repeated checks to an if clause. The old code had const bool ccnr = (options->auth_user_pass_verify_script || PLUGIN_OPTION_LIST(options) || MAN_CLIENT_AUTH_ENABLED(options)); followed by several condition that checked !ccnr This commit fixes the if clause by correctly applying De Morgan's law. Github: closes #706 Change-Id: I28a8abd0ee3fa9168a716171b0a405476089c4a1 Signed-off-by: Arne Schwabe <[email protected]> Acked-by: Antonio Quartulli <[email protected]> Message-Id: <[email protected]> URL: https://sourceforge.net/p/openvpn/mailman/message/59164222/ URL: http://gerrit.openvpn.net/c/openvpn/+/912 Signed-off-by: Gert Doering <[email protected]>
1 parent 6bb20fa commit 15e663c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/openvpn/options.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2752,8 +2752,8 @@ options_postprocess_verify_ce(const struct options *options,
27522752

27532753
}
27542754
if (!options->auth_user_pass_verify_script
2755-
|| PLUGIN_OPTION_LIST(options)
2756-
|| MAN_CLIENT_AUTH_ENABLED(options))
2755+
&& !PLUGIN_OPTION_LIST(options)
2756+
&& !MAN_CLIENT_AUTH_ENABLED(options))
27572757
{
27582758
const char *use_err = "--%s must be used with --management-client-auth, an --auth-user-pass-verify script, or plugin";
27592759

0 commit comments

Comments
 (0)