Optional parameters and params are not a good idea

Christian Wischenbart · Christian Wischenbart · commit 649e61736fd2 · 2019-06-22T23:54:11.000+02:00
diff --git a/src/StreamDeckSharp/StreamDeck.cs b/src/StreamDeckSharp/StreamDeck.cs
@@ -16,14 +16,13 @@ public static class StreamDeck
         /// </summary>
         /// <returns>The default <see cref="IStreamDeckBoard"/> HID</returns>
         /// <exception cref="StreamDeckNotFoundException">Thrown if no Stream Deck is found</exception>
-        public static IStreamDeckBoard OpenDevice(bool useWriteCache = true, params IUsbHidHardware[] hardware)
+        public static IStreamDeckBoard OpenDevice(params IUsbHidHardware[] hardware)
         {
             var dev = EnumerateDevices(hardware).FirstOrDefault();
 
             if (dev is null)
                 throw new StreamDeckNotFoundException();
 
-            dev.UseWriteCache = useWriteCache;
             return dev.Open();
         }
 

Original file line number	Diff line number	Diff line change
`@@ -16,14 +16,13 @@ public static class StreamDeck`
`16`	`16`	`/// </summary>`
`17`	`17`	`/// <returns>The default <see cref="IStreamDeckBoard"/> HID</returns>`
`18`	`18`	`/// <exception cref="StreamDeckNotFoundException">Thrown if no Stream Deck is found</exception>`
`19`		`- public static IStreamDeckBoard OpenDevice(bool useWriteCache = true, params IUsbHidHardware[] hardware)`
	`19`	`+ public static IStreamDeckBoard OpenDevice(params IUsbHidHardware[] hardware)`
`20`	`20`	`{`
`21`	`21`	`var dev = EnumerateDevices(hardware).FirstOrDefault();`
`22`	`22`
`23`	`23`	`if (dev is null)`
`24`	`24`	`throw new StreamDeckNotFoundException();`
`25`	`25`
`26`		`- dev.UseWriteCache = useWriteCache;`
`27`	`26`	`return dev.Open();`
`28`	`27`	`}`
`29`	`28`