fix(qb): Configure HTTP client with connection pooling and fix resource leaks in qBittorrent client. (#898)

Author: Suyunmeng

pkg/qbittorrent/client.go

@@ -8,6 +8,7 @@ import (
 	"net/http"
 	"net/http/cookiejar"
 	"net/url"
+	"time"
 
 	"github.com/OpenListTeam/OpenList/v4/pkg/utils"
 )
@@ -35,9 +36,21 @@ func New(webuiUrl string) (Client, error) {
 	if err != nil {
 		return nil, err
 	}
+
+	transport := &http.Transport{
+		MaxIdleConns:        10,
+		MaxIdleConnsPerHost: 2,
+		IdleConnTimeout:     30 * time.Second,
+		DisableKeepAlives:   false, // Enable connection reuse
+	}
+	
 	var c = &client{
-		url:    u,
-		client: http.Client{Jar: jar},
+		url: u,
+		client: http.Client{
+			Jar:       jar,
+			Transport: transport,
+			Timeout:   30 * time.Second, // Set overall timeout
+		},
 	}
 
 	err = c.checkAuthorization()
@@ -69,6 +82,7 @@ func (c *client) authorized() bool {
 	if err != nil {
 		return false
 	}
+	defer resp.Body.Close()
 	return resp.StatusCode == 200 // the status code will be 403 if not authorized
 }
 
@@ -82,6 +96,7 @@ func (c *client) login() error {
 	if err != nil {
 		return err
 	}
+	defer resp.Body.Close()
 
 	// check result
 	body := make([]byte, 2)
@@ -157,6 +172,7 @@ func (c *client) AddFromLink(link string, savePath string, id string) error {
 	if err != nil {
 		return err
 	}
+	defer resp.Body.Close()
 
 	// check result
 	body := make([]byte, 2)
@@ -271,6 +287,7 @@ func (c *client) GetInfo(id string) (TorrentInfo, error) {
 	if err != nil {
 		return TorrentInfo{}, err
 	}
+	defer response.Body.Close()
 
 	body, err := io.ReadAll(response.Body)
 	if err != nil {
@@ -316,6 +333,7 @@ func (c *client) GetFiles(id string) ([]FileInfo, error) {
 	if err != nil {
 		return []FileInfo{}, err
 	}
+	defer response.Body.Close()
 
 	body, err := io.ReadAll(response.Body)
 	if err != nil {
@@ -345,21 +363,23 @@ func (c *client) Delete(id string, deleteFiles bool) error {
 	} else {
 		v.Set("deleteFiles", "false")
 	}
-	response, err := c.post("/api/v2/torrents/delete", v)
+	deleteResp, err := c.post("/api/v2/torrents/delete", v)
 	if err != nil {
 		return err
 	}
-	if response.StatusCode != 200 {
+	defer deleteResp.Body.Close()
+	if deleteResp.StatusCode != 200 {
 		return errors.New("failed to delete qbittorrent task")
 	}
 
 	v = url.Values{}
 	v.Set("tags", "openlist-"+id)
-	response, err = c.post("/api/v2/torrents/deleteTags", v)
+	deleteTagsResp, err := c.post("/api/v2/torrents/deleteTags", v)
 	if err != nil {
 		return err
 	}
-	if response.StatusCode != 200 {
+	defer deleteTagsResp.Body.Close()
+	if deleteTagsResp.StatusCode != 200 {
 		return errors.New("failed to delete qbittorrent tag")
 	}
 	return nil