feat: support workflow on=schedule values (#89)

Closes #84

Author: OmarTawfik

src/binding/binder.ts

@@ -33,6 +33,8 @@ import { TokenKind } from "../scanning/tokens";
 import * as webhooks from "@octokit/webhooks-definitions";
 import { MAXIMUM_SUPPORTED_VERSION, USES_REGEX } from "../util/constants";
 
+const ON_SCHEDULE_REGEX = /schedule\(.+\)/;
+
 export function bindDocument(root: DocumentSyntax, bag: DiagnosticBag): BoundDocument {
   let version: BoundVersion | undefined;
   const workflows = Array<BoundWorkflow>();
@@ -96,8 +98,11 @@ export function bindDocument(root: DocumentSyntax, bag: DiagnosticBag): BoundDoc
             bag.propertyAlreadyDefined(property.key);
           } else {
             on = new BoundOn(bindString(property), property);
-            if (on.event && !webhooks.some(definition => definition.name === on!.event!.value)) {
-              bag.unrecognizedEvent(on.event.value, on.event.syntax.range);
+            if (on.event) {
+              const { value } = on.event;
+              if (!webhooks.some(definition => definition.name === value) && !ON_SCHEDULE_REGEX.test(value)) {
+                bag.unrecognizedEvent(value, on.event.syntax.range);
+              }
             }
           }
           break;

src/util/diagnostics.ts

@@ -314,7 +314,7 @@ export class DiagnosticBag {
       code: DiagnosticCode.UnrecognizedEvent,
       source: LANGUAGE_NAME,
       severity: DiagnosticSeverity.Error,
-      message: `The event '${event}' is not a known event type.`,
+      message: `The event '${event}' is not a known event type or a schedule.`,
     });
   }
 

test/binding.spec.ts

@@ -257,13 +257,44 @@ workflow "y" {
   on = "unknown"
 }`).toMatchInlineSnapshot(`
 "
-ERROR: The event 'unknown' is not a known event type.
+ERROR: The event 'unknown' is not a known event type or a schedule.
   4 | }
   5 | workflow \\"y\\" {
   6 |   on = \\"unknown\\"
     |        ^^^^^^^^^
   7 | }
 "
+`);
+  });
+
+  it("does not report errors on schedule values", () => {
+    expectDiagnostics(`
+workflow "a" {
+  on = "schedule(*/15 * * * *)"
+}
+workflow "b" {
+  on = "schedule()"
+}
+workflow "c" {
+  on = "  schedule  (  )  "
+}
+`).toMatchInlineSnapshot(`
+"
+ERROR: The event 'schedule()' is not a known event type or a schedule.
+  4 | }
+  5 | workflow \\"b\\" {
+  6 |   on = \\"schedule()\\"
+    |        ^^^^^^^^^^^^
+  7 | }
+  8 | workflow \\"c\\" {
+ERROR: The event '  schedule  (  )  ' is not a known event type or a schedule.
+  7 | }
+  8 | workflow \\"c\\" {
+  9 |   on = \\"  schedule  (  )  \\"
+    |        ^^^^^^^^^^^^^^^^^^^^
+ 10 | }
+ 11 | 
+"
 `);
   });
 });