fix : (RequestBuilder.Uri.cs) Encode only query values instead of whole query string

Author: SCHUMACHER Brice

CHANGELOG.md

@@ -12,4 +12,10 @@
 
 ### 🛠 Technical
 
-- Minor bug fixes on tools (CI, csproj, etc...)
+- Minor bug fixes on tools (CI, csproj, etc...)
+
+## 202
+
+### 🐛 Bug Fixes
+
+- Fixed a bug where the entire query string was encoded instead of only the query parameter keys and values.

NotoriousClient.Tests.Unit/RequestBuilderURIUnitTests.cs

@@ -6,20 +6,20 @@ namespace NotoriousClient.Tests.Unit
     public class RequestBuilderURIUnitTests
     {
         #region URI
-        [GWTFact(given: "a url, an endpoint, and an HTTP Verb", 
-                 when: "i build a request", 
+        [GWTFact(given: "a url, an endpoint, and an HTTP Verb",
+                 when: "i build a request",
                  then: "request has right url, endpoint and verb")]
         public void RequestBuilder_Should_HaveRightUrlEndpointAndVerb()
         {
             string url = "https://toto.com";
             Endpoint endpoint = new Endpoint("/pandas", Method.Get);
 
             RequestBuilder requestBuilder = new RequestBuilder(url, endpoint);
-            HttpRequestMessage request  = requestBuilder.Build();
+            HttpRequestMessage request = requestBuilder.Build();
 
             Assert.Equal(HttpMethod.Get, request.Method);
             Assert.NotNull(request.RequestUri);
-            Assert.Equal("https://toto.com/pandas", request.RequestUri!.ToString());
+            Assert.Equal("https://toto.com/pandas", request.RequestUri.AbsoluteUri);
         }
 
         [GWTFact(given: "a url with and end slash, an endpoint with a start slash, and an HTTP Verb",
@@ -35,7 +35,7 @@ public void RequestBuilder_Should_HandleUrlSlashProperly()
 
             Assert.Equal(HttpMethod.Get, request.Method);
             Assert.NotNull(request.RequestUri);
-            Assert.Equal("https://toto.com/pandas", request.RequestUri!.ToString());
+            Assert.Equal("https://toto.com/pandas", request.RequestUri.AbsoluteUri);
         }
 
         [GWTFact(given: "a url, an endpoint, and an HTTP Verb",
@@ -51,7 +51,7 @@ public void RequestBuilder_Should_AddUrlSlashProperly()
 
             Assert.Equal(HttpMethod.Get, request.Method);
             Assert.NotNull(request.RequestUri);
-            Assert.Equal("https://toto.com/pandas", request.RequestUri!.ToString());
+            Assert.Equal("https://toto.com/pandas", request.RequestUri.AbsoluteUri);
         }
         #endregion
 
@@ -70,7 +70,7 @@ public void RequestBuilder_Should_HaveOneQueryParams()
 
             Assert.Equal(HttpMethod.Get, request.Method);
             Assert.NotNull(request.RequestUri);
-            Assert.Equal("https://toto.com/pandas?toto%3dtoto", request.RequestUri!.ToString());
+            Assert.Equal("https://toto.com/pandas?toto=toto", request.RequestUri.AbsoluteUri);
         }
 
         [GWTFact(given: "a request with two query parameters",
@@ -88,7 +88,24 @@ public void RequestBuilder_Should_HaveTwoQueryParams()
 
             Assert.Equal(HttpMethod.Get, request.Method);
             Assert.NotNull(request.RequestUri);
-            Assert.Equal("https://toto.com/pandas?toto%3dtoto%26toto2%3dtoto2", request.RequestUri!.ToString());
+            Assert.Equal("https://toto.com/pandas?toto=toto&toto2=toto2", request.RequestUri.AbsoluteUri);
+        }
+
+        [GWTFact(given: "a request with one query parameters that have an accent",
+         when: "i build a request",
+         then: "request has encoded query values")]
+        public void RequestBuilder_Should_ShouldEncodeQueryValues()
+        {
+            string url = "https://toto.com";
+            Endpoint endpoint = new Endpoint("/pandas", Method.Get);
+
+            IRequestBuilder requestBuilder = new RequestBuilder(url, endpoint)
+                .AddQueryParameter("této", "této");
+            HttpRequestMessage request = requestBuilder.Build();
+
+            Assert.Equal(HttpMethod.Get, request.Method);
+            Assert.NotNull(request.RequestUri);
+            Assert.Equal("https://toto.com/pandas?t%C3%A9to=t%C3%A9to", request.RequestUri.AbsoluteUri);
         }
         #endregion
 

NotoriousClient/Builder/RequestBuilder.Uri.cs

@@ -1,6 +1,4 @@
-using System;
-using System.Collections.Specialized;
-using System.Web;
+using System.Web;
 
 namespace NotoriousClient.Builder
 {
@@ -82,14 +80,14 @@ private string HandleUriQueryParams(string uri, Dictionary<string, string> query
         {
             if (queryParams.Count > 0)
             {
-                string queryParamsString = string.Join("&", queryParams.Select(kvp => string.Format("{0}={1}", kvp.Key, kvp.Value)));
-                return string.Format(uri + "?{0}", HttpUtility.UrlEncode(queryParamsString));
+                string queryParamsString = string.Join("&", queryParams.Select(kvp => string.Format("{0}={1}", HttpUtility.UrlEncode(kvp.Key), HttpUtility.UrlEncode(kvp.Value))));
+                return string.Format(uri + "?{0}", queryParamsString);
             }
             else
             {
                 return uri;
             }
-            
+
         }
 
         private string HandleUriEndPointParams(string uri, Dictionary<string, string> endPointParams)

NotoriousClient/NotoriousClient.csproj

@@ -5,7 +5,7 @@
 		<PackageId>NotoriousClient</PackageId>
 		<ImplicitUsings>enable</ImplicitUsings>
 		<Nullable>enable</Nullable>
-		<VersionPrefix>2.0.1</VersionPrefix>
+		<VersionPrefix>2.0.2</VersionPrefix>
 		<PackageReadmeFile>README.md</PackageReadmeFile>
 		<Authors>Brice SCHUMACHER</Authors>
 		<RepositoryUrl>https://github.com/Notorious-Coding/Notorious-Client/</RepositoryUrl>