Skip to content
This repository was archived by the owner on Feb 7, 2019. It is now read-only.

Commit 3d1d99e

Browse files
authored
Merge pull request #181 from NativeScript/lini/update-firebase-and-cache
fix for Android data only notifications when app is closed
2 parents 6971682 + 1e1f8a5 commit 3d1d99e

File tree

4 files changed

+12
-19
lines changed

4 files changed

+12
-19
lines changed

native-src/android/app/app.iml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -111,22 +111,22 @@
111111
</content>
112112
<orderEntry type="jdk" jdkName="Android API 26 Platform" jdkType="Android SDK" />
113113
<orderEntry type="sourceFolder" forTests="false" />
114-
<orderEntry type="library" name="com.google.firebase:firebase-iid-11.6.2" level="project" />
114+
<orderEntry type="library" name="com.google.firebase:firebase-iid-11.8.0" level="project" />
115115
<orderEntry type="library" name="com.android.support:support-core-utils-25.2.0" level="project" />
116-
<orderEntry type="library" name="com.google.firebase:firebase-iid-license-11.6.2" level="project" />
117-
<orderEntry type="library" name="com.google.android.gms:play-services-basement-11.6.2" level="project" />
118-
<orderEntry type="library" name="com.google.firebase:firebase-messaging-license-11.6.2" level="project" />
119-
<orderEntry type="library" name="com.google.firebase:firebase-common-11.6.2" level="project" />
120-
<orderEntry type="library" name="com.google.android.gms:play-services-tasks-11.6.2" level="project" />
116+
<orderEntry type="library" name="com.google.firebase:firebase-iid-license-11.8.0" level="project" />
117+
<orderEntry type="library" name="com.google.android.gms:play-services-basement-11.8.0" level="project" />
118+
<orderEntry type="library" name="com.google.firebase:firebase-messaging-license-11.8.0" level="project" />
119+
<orderEntry type="library" name="com.google.firebase:firebase-common-11.8.0" level="project" />
121120
<orderEntry type="library" name="com.android.support:support-core-ui-25.2.0" level="project" />
122-
<orderEntry type="library" name="com.google.firebase:firebase-common-license-11.6.2" level="project" />
123-
<orderEntry type="library" name="com.google.firebase:firebase-messaging-11.6.2" level="project" />
121+
<orderEntry type="library" name="com.google.android.gms:play-services-tasks-11.8.0" level="project" />
122+
<orderEntry type="library" name="com.google.firebase:firebase-common-license-11.8.0" level="project" />
123+
<orderEntry type="library" name="com.google.firebase:firebase-messaging-11.8.0" level="project" />
124124
<orderEntry type="library" name="com.android.support:support-media-compat-25.2.0" level="project" />
125125
<orderEntry type="library" name="com.android.support:support-compat-25.2.0" level="project" />
126-
<orderEntry type="library" name="com.google.android.gms:play-services-basement-license-11.6.2" level="project" />
126+
<orderEntry type="library" name="com.google.android.gms:play-services-basement-license-11.8.0" level="project" />
127127
<orderEntry type="library" name="com.android.support:support-annotations:25.2.0@jar" level="project" />
128128
<orderEntry type="library" name="com.android.support:support-v4-25.2.0" level="project" />
129-
<orderEntry type="library" name="com.google.android.gms:play-services-tasks-license-11.6.2" level="project" />
130129
<orderEntry type="library" name="com.android.support:support-fragment-25.2.0" level="project" />
130+
<orderEntry type="library" name="com.google.android.gms:play-services-tasks-license-11.8.0" level="project" />
131131
</component>
132132
</module>

native-src/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ android {
2121
dependencies {
2222
compile fileTree(dir: 'libs', include: ['*.jar'])
2323
// compile 'com.android.support:appcompat-v7:25.1.0'
24-
compile 'com.google.firebase:firebase-messaging:11.6.2'
24+
compile 'com.google.firebase:firebase-messaging:11.8.0'
2525
}
2626

2727
gradle.buildFinished {

native-src/android/app/src/main/java/com/telerik/pushplugin/PushPlugin.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -124,14 +124,7 @@ public void onMessageReceived(RemoteMessage message) {
124124
Log.d(TAG, "Notification body: " + notif.getBody());
125125
}
126126

127-
boolean isCallbackRegistered = onMessageReceivedCallback != null;
128-
Log.d(TAG, "Callback is registered: " + isCallbackRegistered);
129-
130-
// If the application has the callback registered
131-
// execute the callback. Otherwise, let the OS handle the notification.
132-
if (isCallbackRegistered) {
133-
executeOnMessageReceivedCallback(data, notif);
134-
}
127+
executeOnMessageReceivedCallback(data, notif);
135128
}
136129

137130
/**
-77 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)