Skip to content

Conversation

Pouyanpi
Copy link
Collaborator

@Pouyanpi Pouyanpi commented Jul 25, 2025

[GENERATED BY COPILOT]

This pull request revises the tracing documentation for NeMo Guardrails, streamlining the configuration process and aligning it with OpenTelemetry best practices. Key changes include simplifying the tracing setup, emphasizing application-level SDK configuration, and providing detailed examples for production and development environments.

Updates to Tracing Documentation:

Simplification of Configuration:

  • Removed outdated and overly detailed examples in docs/user-guides/configuration-guide.md. The new approach focuses on enabling tracing in config.yml with minimal configuration and highlights the FileSystem and OpenTelemetry adapters for development and production use.

New Tracing Guide:

  • Added docs/user-guides/tracing.md, which provides a comprehensive guide to tracing, including quick start instructions, adapter types, OpenTelemetry integration, and setup examples for development and production environments.

OpenTelemetry Best Practices:

  • Updated documentation to follow OpenTelemetry standards where libraries use only the API, and applications configure the SDK. Deprecated functions like register_otel_exporter() are noted, with migration examples provided.

Enhanced Ecosystem Compatibility:

  • Detailed compatibility with OpenTelemetry exporters (e.g., Jaeger, Zipkin), collectors, and backends, including setup instructions for common integrations.

Support for Custom Adapters:

  • Added examples for creating and registering custom InteractionLogAdapter classes for specialized backends or formats.

#1287

@Pouyanpi Pouyanpi added this to the v0.15.0 milestone Jul 25, 2025
@Pouyanpi Pouyanpi added the documentation Improvements or additions to documentation label Jul 25, 2025
@Pouyanpi Pouyanpi requested review from Copilot and miyoungc July 25, 2025 14:05
@Pouyanpi Pouyanpi marked this pull request as ready for review July 25, 2025 14:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request revises the tracing documentation for NeMo Guardrails, streamlining the configuration process and aligning it with OpenTelemetry best practices. The documentation is restructured to provide clearer guidance for both development and production environments.

  • Simplifies tracing configuration by removing complex examples and focusing on minimal configuration
  • Adds a comprehensive new tracing guide with detailed OpenTelemetry integration examples
  • Aligns with OpenTelemetry best practices where libraries use the API and applications configure the SDK

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
docs/user-guides/tracing.md New comprehensive tracing guide with quick start, adapter configurations, OpenTelemetry integration examples, and migration guidance
docs/user-guides/configuration-guide.md Streamlined tracing section with simplified configuration examples and reference to the detailed tracing guide

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.45%. Comparing base (b574cec) to head (caf0f98).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1307   +/-   ##
========================================
  Coverage    70.45%   70.45%           
========================================
  Files          161      161           
  Lines        16214    16214           
========================================
  Hits         11423    11423           
  Misses        4791     4791           
Flag Coverage Δ
python 70.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NVIDIA-NeMo NVIDIA-NeMo deleted a comment from github-actions bot Jul 29, 2025
Copy link
Contributor

Documentation preview

https://nvidia.github.io/NeMo-Guardrails/review/pr-1307

fix hyperlink
@Pouyanpi Pouyanpi self-assigned this Jul 29, 2025
@Pouyanpi
Copy link
Collaborator Author

@miyoungc merged #1310 and made the necessary adjustments 👍🏻

@Pouyanpi Pouyanpi merged commit bee719b into develop Jul 29, 2025
19 checks passed
@Pouyanpi Pouyanpi deleted the docs/tracing branch July 29, 2025 16:35
Pouyanpi added a commit that referenced this pull request Oct 1, 2025
* docs(tracing): remove common integrations section

* docs: restructure and edit content for the tracing feature update (#1310)

---------

Co-authored-by: Miyoung Choi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants