Fix RenameVariables switching case with scopes (#1472)

Author: bhirsz

docs/releasenotes/6.7.1.rst

@@ -27,10 +27,8 @@ Robocop is executed on the same major version (6.1.1 for example) without target
 Importing external modules in custom rules with the same name as Robocop rules fails (#1467)
 --------------------------------------------------------------------------------------------
 
-If custom rule used external module with the same name as one of Robocop rules categories, it failed on import:
+If custom rule used external module with the same name as one of Robocop rules categories, it failed on import::
 
-```
-from deprecated import deprecated  # duplicates with robocop.linter.rules.deprecated.py
-```
+    from deprecated import deprecated  # duplicates with robocop.linter.rules.deprecated.py
 
 It was resolved by redesigning our rules importing logic to follow the same behaviour as formatter importer.

docs/releasenotes/6.7.2.rst

@@ -5,12 +5,10 @@ Robocop 6.7.2
 Assertion keywords reported as undefined-argument-value (#1390)
 ---------------------------------------------------------------
 
-Assertion keywords used by popular ``AssertionEngine`` library were reported as ``undefined-argument-value`` errors:
+Assertion keywords used by popular ``AssertionEngine`` library were reported as ``undefined-argument-value`` errors::
 
-```
- 785 |   Get Text   ${selector}   *=   ${alv_check}
-     |                            ^^ ARG04
-```
+     785 |   Get Text   ${selector}   *=   ${alv_check}
+         |                            ^^ ARG04
 
 Robocop should now ignore arguments that match following list: "==", "!=", "<", ">", "<=", ">=", "*=", "^=", "$=", "$".
 
@@ -19,3 +17,50 @@ SonarQube import issues with diagnostic outside physical locations (#1417)
 
 Fixed issues when reporting SPC10 ``too-many-trailing-blank-lines`` and LEN08 ``line-too-long`` outside physical
 locations. Now it should only report start/end lines.
+
+RenameVariables lower-casing VAR variables with global scope (#1425)
+--------------------------------------------------------------------
+
+Following code::
+
+    *** Keywords ***
+    Some keyword
+        &{SOME_DICT}    Some keyword that returns a dict
+        VAR    &{SOME_DICT}    &{SOME_DICT}   scope=TEST
+
+was incorrectly converted to::
+
+    *** Keywords ***
+    Some keyword
+        &{some_dict}    Some keyword that returns a dict
+        VAR    &{some_dict}    &{some_dict}   scope=TEST
+
+It should now correctly detect new (global) case of variable and convert it to::
+
+    *** Keywords ***
+    Some keyword
+        &{some_dict}    Some keyword that returns a dict
+        VAR    &{SOME_DICT}    &{some_dict}   scope=TEST
+
+RenameVariables VAR variables stuck forever with local scope (#1425)
+--------------------------------------------------------------------
+
+When using VAR with local scope, VAR did not change back to global scope after switching scope again.
+
+Following code::
+
+    *** Keywords ***
+    Some keyword
+        VAR    ${local_variable}    scope=local
+        Log    ${local_variable}
+        VAR    ${local_variable}    scope=SUITE
+        Log    ${local_variable}
+
+will now be formatted to::
+
+    *** Keywords ***
+    Some keyword
+        VAR    ${local_variable}    scope=local
+        Log    ${local_variable}
+        VAR    ${LOCAL_VARIABLE}    scope=SUITE
+        Log    ${LOCAL_VARIABLE}

src/robocop/formatter/formatters/RenameVariables.py

@@ -458,7 +458,10 @@ def visit_Var(self, node):  # noqa: N802
         if variable:
             if self._is_var_scope_local(node):
                 self.variables_scope.add_local(variable.value)
-            variable.value = self.rename_value(variable.value, variable_case=VariableCase.AUTO, is_var=False)
+                variable.value = self.rename_value(variable.value, variable_case=VariableCase.LOWER, is_var=False)
+            else:
+                self.variables_scope.change_scope_from_local_to_global(variable.value)
+                variable.value = self.rename_value(variable.value, variable_case=VariableCase.UPPER, is_var=False)
         return node
 
     @staticmethod

tests/formatter/formatters/RenameVariables/expected/VAR_syntax.robot

@@ -21,6 +21,8 @@ Change scope
     VAR    ${SUITE}    value    scope=SUITE
     VAR    ${GLOBAL}    value    scope=GLOBAL
     VAR    ${TEST}    value    scope=TEST
+    &{some_dict}    Some Keyword With Local Return
+    VAR    &{SOME_DICT}    &{some_dict}    scope=TEST
     VAR    ${TASK}    value    scope=TASK
     VAR    ${local_default}    value    scope=local
 
@@ -41,6 +43,14 @@ Change scope
     VAR    ${VARIABLE}    value    scope=${dynamic_scope}
     Log    ${VARIABLE}
 
+    # change scope again
+    Log    ${TEST}
+    VAR    ${test}    value    scope=local
+    Log    ${test}
+    VAR    ${TEST}    value    scope=TEST
+    Log    ${TEST}
+    VAR    &{some_dict}    &{SOME_DICT}
+
 List
     # Creates a list with three items.
     VAR    @{list}    a    b    c

tests/formatter/formatters/RenameVariables/source/VAR_syntax.robot

@@ -21,6 +21,8 @@ Change scope
     VAR    ${suite}    value    scope=SUITE
     VAR    ${global}    value    scope=GLOBAL
     VAR    ${test}    value    scope=TEST
+    &{some_dict}    Some Keyword With Local Return
+    VAR    &{some_dict}    &{some_dict}    scope=TEST
     VAR    ${task}    value    scope=TASK
     VAR    ${local_default}    value    scope=local
 
@@ -41,6 +43,14 @@ Change scope
     VAR    ${variable}    value    scope=${dynamic_scope}
     Log    ${variable}
 
+    # change scope again
+    Log    ${TEST}
+    VAR    ${test}    value    scope=local
+    Log    ${test}
+    VAR    ${TEST}    value    scope=TEST
+    Log    ${TEST}
+    VAR    &{some_dict}    &{SOME_DICT}
+
 List
     # Creates a list with three items.
     VAR    @{list}    a    b    c