106106#include " mc/world/scores/ScoreInfo.h"
107107#include " mc/world/scores/Scoreboard.h"
108108#include " mc/world/scores/ScoreboardId.h"
109+ #include " mc/world/scores/ScoreboardOperationResult.h"
109110
110111SetScorePacket::SetScorePacket () = default;
111112
@@ -546,10 +547,10 @@ Local<Value> McClass::setPlayerScore(const Arguments& args) {
546547 if (sid.mRawID == ScoreboardId::INVALID ().mRawID ) {
547548 return Boolean::newBoolean (false );
548549 }
549- bool isSuccess = false ;
550+ ScoreboardOperationResult isSuccess;
550551 scoreboard
551552 .modifyPlayerScore (isSuccess, sid, *objective, args[2 ].asNumber ().toInt32 (), PlayerScoreSetFunction::Set);
552- return Boolean::newBoolean (isSuccess);
553+ return Boolean::newBoolean (isSuccess == ScoreboardOperationResult::Success );
553554 }
554555 CATCH (" Fail in setPlayerScore!" )
555556}
@@ -584,10 +585,10 @@ Local<Value> McClass::addPlayerScore(const Arguments& args) {
584585 if (sid.mRawID == ScoreboardId::INVALID ().mRawID ) {
585586 return Boolean::newBoolean (false );
586587 }
587- bool isSuccess = false ;
588+ ScoreboardOperationResult isSuccess;
588589 scoreboard
589590 .modifyPlayerScore (isSuccess, sid, *objective, args[2 ].asNumber ().toInt32 (), PlayerScoreSetFunction::Add);
590- return Boolean::newBoolean (isSuccess);
591+ return Boolean::newBoolean (isSuccess == ScoreboardOperationResult::Success );
591592 }
592593 CATCH (" Fail in addPlayerScore!" )
593594}
@@ -622,15 +623,15 @@ Local<Value> McClass::reducePlayerScore(const Arguments& args) {
622623 if (sid.mRawID == ScoreboardId::INVALID ().mRawID ) {
623624 return Boolean::newBoolean (false );
624625 }
625- bool isSuccess = false ;
626+ ScoreboardOperationResult isSuccess;
626627 scoreboard.modifyPlayerScore (
627628 isSuccess,
628629 sid,
629630 *objective,
630631 args[2 ].asNumber ().toInt32 (),
631632 PlayerScoreSetFunction::Subtract
632633 );
633- return Boolean::newBoolean (isSuccess);
634+ return Boolean::newBoolean (isSuccess == ScoreboardOperationResult::Success );
634635 }
635636 CATCH (" Fail in reducePlayerScore!" )
636637}
@@ -1430,8 +1431,7 @@ Local<Value> PlayerClass::isMoving() {
14301431 return Local<Value>();
14311432 }
14321433
1433- return Boolean::newBoolean (
1434- SynchedActorDataAccess::getActorFlag (player->getEntityContext (), ActorFlags::Moving)
1434+ return Boolean::newBoolean (SynchedActorDataAccess::getActorFlag (player->getEntityContext (), ActorFlags::Moving)
14351435 );
14361436 }
14371437 CATCH (" Fail in isMoving!" )
@@ -2161,9 +2161,9 @@ Local<Value> PlayerClass::setScore(const Arguments& args) {
21612161 if (id.mRawID == ScoreboardId::INVALID ().mRawID ) {
21622162 scoreboard.createScoreboardId (*player);
21632163 }
2164- bool isSuccess = false ;
2164+ ScoreboardOperationResult isSuccess;
21652165 scoreboard.modifyPlayerScore (isSuccess, id, *obj, args[1 ].asNumber ().toInt32 (), PlayerScoreSetFunction::Set);
2166- return Boolean::newBoolean (isSuccess);
2166+ return Boolean::newBoolean (isSuccess == ScoreboardOperationResult::Success );
21672167 }
21682168 CATCH (" Fail in setScore!" );
21692169}
@@ -2186,9 +2186,9 @@ Local<Value> PlayerClass::addScore(const Arguments& args) {
21862186 if (id.mRawID == ScoreboardId::INVALID ().mRawID ) {
21872187 scoreboard.createScoreboardId (*player);
21882188 }
2189- bool isSuccess = false ;
2189+ ScoreboardOperationResult isSuccess;
21902190 scoreboard.modifyPlayerScore (isSuccess, id, *obj, args[1 ].asNumber ().toInt32 (), PlayerScoreSetFunction::Add);
2191- return Boolean::newBoolean (isSuccess);
2191+ return Boolean::newBoolean (isSuccess == ScoreboardOperationResult::Success );
21922192 }
21932193 CATCH (" Fail in addScore!" );
21942194}
@@ -2211,10 +2211,10 @@ Local<Value> PlayerClass::reduceScore(const Arguments& args) {
22112211 if (id.mRawID == ScoreboardId::INVALID ().mRawID ) {
22122212 scoreboard.createScoreboardId (*player);
22132213 }
2214- bool isSuccess = false ;
2214+ ScoreboardOperationResult isSuccess;
22152215 scoreboard
22162216 .modifyPlayerScore (isSuccess, id, *obj, args[1 ].asNumber ().toInt32 (), PlayerScoreSetFunction::Subtract);
2217- return Boolean::newBoolean (isSuccess);
2217+ return Boolean::newBoolean (isSuccess == ScoreboardOperationResult::Success );
22182218 }
22192219 CATCH (" Fail in reduceScore!" );
22202220}
@@ -2454,8 +2454,7 @@ Local<Value> PlayerClass::sendSimpleForm(const Arguments& args) {
24542454 }
24552455 }
24562456 auto formCallback = [engine{EngineScope::currentEngine ()},
2457- callback{
2458- script::Global (args[4 ].asFunction ())
2457+ callback{script::Global (args[4 ].asFunction ())
24592458 }](Player& pl, int chosen, ll::form::FormCancelReason reason) {
24602459 if ((ll::getGamingStatus () != ll::GamingStatus::Running)) return ;
24612460 if (!EngineManager::isValid (engine)) return ;
@@ -2499,10 +2498,9 @@ Local<Value> PlayerClass::sendModalForm(const Arguments& args) {
24992498 args[2 ].asString ().toString (),
25002499 args[3 ].asString ().toString ()
25012500 );
2502- auto formCallback = [engine{EngineScope::currentEngine ()}, callback{script::Global (args[4 ].asFunction ())}](
2503- Player& pl,
2504- ll::form::ModalFormResult const & chosen,
2505- ll::form::FormCancelReason reason
2501+ auto formCallback = [engine{EngineScope::currentEngine ()},
2502+ callback{script::Global (args[4 ].asFunction ())
2503+ }](Player& pl, ll::form::ModalFormResult const & chosen, ll::form::FormCancelReason reason
25062504 ) {
25072505 if ((ll::getGamingStatus () != ll::GamingStatus::Running)) return ;
25082506 if (!EngineManager::isValid (engine)) return ;
0 commit comments