Skip to content

Commit f097cdc

Browse files
remove experimental api
remove experimental apiMerge pull request #13 from LeonDevLifeLog/fix/experimental-api
2 parents 0623e82 + b03f084 commit f097cdc

File tree

7 files changed

+39
-29
lines changed

7 files changed

+39
-29
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,20 @@
44

55
## [Unreleased]
66

7+
### Fixed
8+
9+
- issues about plugin verification
10+
711
## [0.2.1] - 2023-08-16
812

913
### Fixed
14+
1015
- issues about plugin verification
1116

1217
## [0.2.0] - 2023-08-14
1318

1419
### Added
20+
1521
- Support Clone Gitea Repository
1622

1723
## [0.2.0-beta] - 2023-08-13

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ pluginGroup = com.github.leondevlifelog.gitea
44
pluginName = Gitea
55
pluginRepositoryUrl = https://github.com/LeonDevLifeLog/gitea-idea-plugin
66
# SemVer format -> https://semver.org
7-
pluginVersion = 0.2.1
7+
pluginVersion=0.2.2
88

99
# Supported build number ranges and IntelliJ Platform versions -> https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
1010
pluginSinceBuild = 223

src/main/kotlin/com/github/leondevlifelog/gitea/api/GiteaRepositoryCoordinates.kt

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,14 @@
55

66
package com.github.leondevlifelog.gitea.api
77

8-
98
import com.github.leondevlifelog.gitea.authentication.accounts.GiteaServerPath
109
import com.intellij.collaboration.util.resolveRelative
11-
import git4idea.remote.hosting.HostedRepositoryCoordinates
1210
import com.intellij.openapi.util.NlsSafe
1311
import java.net.URI
1412

1513
data class GiteaRepositoryCoordinates(
16-
override val serverPath: GiteaServerPath, val repositoryPath: GiteaRepositoryPath
17-
) : HostedRepositoryCoordinates {
14+
val serverPath: GiteaServerPath, val repositoryPath: GiteaRepositoryPath
15+
) {
1816

1917
fun toUrl(): String {
2018
return serverPath.toURI().toString() + "/" + repositoryPath
@@ -32,9 +30,7 @@ data class GiteaRepositoryCoordinates(
3230
if (other !is GiteaRepositoryCoordinates) return false
3331

3432
if (serverPath != other.serverPath) return false
35-
if (repositoryPath != other.repositoryPath) return false
36-
37-
return true
33+
return repositoryPath == other.repositoryPath
3834
}
3935

4036
override fun hashCode(): Int {

src/main/kotlin/com/github/leondevlifelog/gitea/ui/GiteaLoginDialog.kt

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,17 @@ package com.github.leondevlifelog.gitea.ui
88
import com.github.leondevlifelog.gitea.GiteaBundle
99
import com.github.leondevlifelog.gitea.authentication.accounts.GiteaAccountManager
1010
import com.github.leondevlifelog.gitea.authentication.accounts.GiteaServerPath
11-
import com.intellij.collaboration.async.DisposingMainScope
1211
import com.intellij.openapi.application.ModalityState
1312
import com.intellij.openapi.application.asContextElement
1413
import com.intellij.openapi.components.service
1514
import com.intellij.openapi.project.Project
1615
import com.intellij.openapi.ui.DialogWrapper
1716
import com.intellij.openapi.ui.DialogWrapper.IS_VISUAL_PADDING_COMPENSATED_ON_COMPONENT_LEVEL_KEY
1817
import com.intellij.openapi.ui.ValidationInfo
18+
import com.intellij.openapi.util.Disposer
1919
import com.intellij.openapi.util.NlsContexts
2020
import git4idea.i18n.GitBundle
21-
import kotlinx.coroutines.CancellationException
22-
import kotlinx.coroutines.Dispatchers
23-
import kotlinx.coroutines.launch
21+
import kotlinx.coroutines.*
2422
import java.awt.Component
2523
import javax.swing.JComponent
2624

@@ -33,7 +31,11 @@ internal sealed class GiteaLoginDialog(
3331
parent: Component?
3432
) : DialogWrapper(project, parent, false, IdeModalityType.PROJECT) {
3533

36-
private val cs = DisposingMainScope(disposable)
34+
private val cs = MainScope().also {
35+
Disposer.register(disposable!!) {
36+
it.cancel()
37+
}
38+
}
3739

3840
protected val loginPanel = GiteaLoginPanel() { login, server ->
3941
model.isAccountUnique(server, login)
@@ -61,8 +63,7 @@ internal sealed class GiteaLoginDialog(
6163
accountManager.updateAccount(acc, token)
6264
model.saveLogin(loginPanel.getServer(), login, token)
6365
close(OK_EXIT_CODE, true)
64-
}
65-
catch (e: Exception) {
66+
} catch (e: Exception) {
6667
if (e is CancellationException) {
6768
close(CANCEL_EXIT_CODE, false)
6869
throw e

src/main/kotlin/com/github/leondevlifelog/gitea/ui/GiteaSettingsConfigurable.kt

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,17 @@ import com.github.leondevlifelog.gitea.GiteaConfig
1010
import com.github.leondevlifelog.gitea.authentication.accounts.GiteaAccountManager
1111
import com.github.leondevlifelog.gitea.authentication.accounts.GiteaProjectDefaultAccountHolder
1212
import com.github.leondevlifelog.gitea.services.GiteaSettings
13-
import com.intellij.collaboration.async.DisposingMainScope
1413
import com.intellij.collaboration.auth.ui.AccountsPanelFactory
1514
import com.intellij.openapi.application.ModalityState
1615
import com.intellij.openapi.application.asContextElement
1716
import com.intellij.openapi.components.service
1817
import com.intellij.openapi.options.BoundConfigurable
1918
import com.intellij.openapi.project.Project
2019
import com.intellij.openapi.ui.DialogPanel
20+
import com.intellij.openapi.util.Disposer
2121
import com.intellij.ui.dsl.builder.*
22+
import kotlinx.coroutines.MainScope
23+
import kotlinx.coroutines.cancel
2224
import kotlinx.coroutines.plus
2325

2426
class GiteaSettingsConfigurable internal constructor(private val project: Project) :
@@ -28,7 +30,11 @@ class GiteaSettingsConfigurable internal constructor(private val project: Projec
2830
val accountManager = service<GiteaAccountManager>()
2931
val settings = GiteaSettings.getInstance()
3032

31-
val scope = DisposingMainScope(disposable!!) + ModalityState.any().asContextElement()
33+
val scope = MainScope().also {
34+
Disposer.register(disposable!!) {
35+
it.cancel()
36+
}
37+
} + ModalityState.any().asContextElement()
3238
val accountsModel = GiteaAccountsListModel()
3339
val detailsProvider = GiteaAccountsDetailsProvider(scope, accountManager, accountsModel)
3440

src/main/kotlin/com/github/leondevlifelog/gitea/ui/clone/CloneDialogLoginPanel.kt

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import com.github.leondevlifelog.gitea.GiteaBundle
99
import com.github.leondevlifelog.gitea.authentication.accounts.GiteaAccount
1010
import com.github.leondevlifelog.gitea.authentication.accounts.GiteaAccountManager
1111
import com.github.leondevlifelog.gitea.ui.GiteaLoginPanel
12-
import com.intellij.collaboration.async.disposingMainScope
1312
import com.intellij.ide.IdeBundle
1413
import com.intellij.openapi.Disposable
1514
import com.intellij.openapi.actionSystem.ActionUpdateThread
@@ -22,6 +21,7 @@ import com.intellij.openapi.components.service
2221
import com.intellij.openapi.project.DumbAwareAction
2322
import com.intellij.openapi.ui.ComponentValidator
2423
import com.intellij.openapi.ui.ValidationInfo
24+
import com.intellij.openapi.util.Disposer
2525
import com.intellij.openapi.wm.IdeFocusManager
2626
import com.intellij.ui.SimpleColoredComponent
2727
import com.intellij.ui.SimpleTextAttributes.ERROR_ATTRIBUTES
@@ -34,10 +34,7 @@ import com.intellij.util.ui.JBInsets
3434
import com.intellij.util.ui.JBUI.Borders.empty
3535
import com.intellij.util.ui.JBUI.Panels.simplePanel
3636
import com.intellij.util.ui.UIUtil.getRegularPanelInsets
37-
import kotlinx.coroutines.CancellationException
38-
import kotlinx.coroutines.Dispatchers
39-
import kotlinx.coroutines.Job
40-
import kotlinx.coroutines.async
37+
import kotlinx.coroutines.*
4138
import java.awt.Dimension
4239
import java.awt.LayoutManager
4340
import java.awt.Rectangle
@@ -46,7 +43,11 @@ import javax.swing.*
4643
internal class CloneDialogLoginPanel(private val account: GiteaAccount?) :
4744
JBPanel<CloneDialogLoginPanel>(ListLayout.vertical(0)), Disposable {
4845

49-
private val cs = disposingMainScope()
46+
private val cs = MainScope().also {
47+
Disposer.register(this) {
48+
it.cancel()
49+
}
50+
}
5051

5152
private val accountManager get() = service<GiteaAccountManager>()
5253

src/main/kotlin/com/github/leondevlifelog/gitea/ui/clone/GiteaCloneDialogExtensionComponentBase.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import com.github.leondevlifelog.gitea.util.GiteaGitHelper
1818
import com.github.leondevlifelog.gitea.util.GiteaNotificationIdsHolder
1919
import com.github.leondevlifelog.gitea.util.GiteaNotifications
2020
import com.github.leondevlifelog.gitea.util.GiteaUrlUtil
21-
import com.intellij.collaboration.async.disposingMainScope
2221
import com.intellij.collaboration.auth.ui.CompactAccountsPanelFactory
2322
import com.intellij.collaboration.ui.CollaborationToolsUIUtil
2423
import com.intellij.collaboration.util.CollectionDelta
@@ -61,12 +60,9 @@ import git4idea.GitUtil
6160
import git4idea.checkout.GitCheckoutProvider
6261
import git4idea.commands.Git
6362
import git4idea.remote.GitRememberedInputs
64-
import kotlinx.coroutines.Dispatchers
65-
import kotlinx.coroutines.async
63+
import kotlinx.coroutines.*
6664
import kotlinx.coroutines.flow.collectLatest
6765
import kotlinx.coroutines.flow.map
68-
import kotlinx.coroutines.launch
69-
import kotlinx.coroutines.plus
7066
import org.jetbrains.annotations.Nls
7167
import java.awt.event.ActionEvent
7268
import java.nio.file.Paths
@@ -89,7 +85,11 @@ public abstract class GiteaCloneDialogExtensionComponentBase(
8985

9086
private val giteaGitHelper: GiteaGitHelper = GiteaGitHelper.getInstance()
9187

92-
private val cs = disposingMainScope() + modalityState.asContextElement()
88+
private val cs = MainScope().also {
89+
Disposer.register(this) {
90+
it.cancel()
91+
}
92+
} + modalityState.asContextElement()
9393

9494
// UI
9595
private val wrapper: Wrapper = Wrapper()

0 commit comments

Comments
 (0)