Move shared NBGL source files to OS, where they are compiled

Author: nroggeman-ledger

.github/workflows/unit_tests.yml

@@ -24,9 +24,6 @@ jobs:
         run: |
           cd unit-tests/lib_standard_app/
           cmake -Bbuild -H. && make -C build && make -C build test
-          cd ../lib_nbgl/
-          cmake -Bbuild -H. && make -C build && CTEST_OUTPUT_ON_FAILURE=1 make -C build test
-          STAX=1 cmake -Bbuild -H. && make -C build && CTEST_OUTPUT_ON_FAILURE=1 make -C build test
           cd ../app_storage/
           cmake -Bbuild -H. && make -C build && make -C build test
           cd ../lib_alloc/
@@ -36,8 +33,6 @@ jobs:
         run: |
           cd unit-tests/lib_standard_app/
           ../gen_coverage.sh
-          cd ../lib_nbgl/
-          ../gen_coverage.sh
           cd ../app_storage/
           ../gen_coverage.sh
           cd ../lib_alloc/

fuzzing/CMakeLists.txt

@@ -103,6 +103,15 @@ else()
   separate_arguments(LINK_FLAGS)
 endif()
 
+# NBGL shared library is generated in Bolos, from NBGL sources from Bolos
+set(NBGL_SHARED_LIB ../../tests/screenshots/shared_libs/libnbgl_shared_${TARGET}.a)
+add_library(nbgl_shared STATIC IMPORTED)
+set_target_properties(
+    nbgl_shared
+      PROPERTIES
+      IMPORTED_LOCATION "${CMAKE_CURRENT_LIST_DIR}/shared_libs/libnbgl_shared_${TARGET}.a"
+  )
+
 # Fuzzing an APP
 if(NOT ${CMAKE_SOURCE_DIR} STREQUAL ${CMAKE_CURRENT_SOURCE_DIR})
   file(GLOB LIBS "${BOLOS_SDK}/fuzzing/libs/*.cmake")

fuzzing/extra/apdu_parser.cmake

@@ -10,4 +10,4 @@ target_compile_options(fuzz_apdu_parser PUBLIC ${COMPILATION_FLAGS})
 target_link_options(fuzz_apdu_parser PUBLIC ${LINK_FLAGS})
 
 # Link with required libraries
-target_link_libraries(fuzz_apdu_parser PUBLIC standard_app)
+target_link_libraries(fuzz_apdu_parser PUBLIC standard_app nbgl_shared)

fuzzing/extra/base58.cmake

@@ -9,4 +9,4 @@ target_compile_options(fuzz_base58 PUBLIC ${COMPILATION_FLAGS})
 target_link_options(fuzz_base58 PUBLIC ${LINK_FLAGS})
 
 # Link with required libraries
-target_link_libraries(fuzz_base58 PUBLIC standard_app)
+target_link_libraries(fuzz_base58 PUBLIC standard_app nbgl_shared)

fuzzing/extra/bip32.cmake

@@ -9,4 +9,4 @@ target_compile_options(fuzz_bip32 PUBLIC ${COMPILATION_FLAGS})
 target_link_options(fuzz_bip32 PUBLIC ${LINK_FLAGS})
 
 # Link with required libraries
-target_link_libraries(fuzz_bip32 PUBLIC standard_app)
+target_link_libraries(fuzz_bip32 PUBLIC standard_app nbgl_shared)

fuzzing/extra/lib_alloc.cmake

@@ -12,4 +12,4 @@ target_compile_options(fuzz_alloc PUBLIC ${COMPILATION_FLAGS})
 target_link_options(fuzz_alloc PUBLIC ${LINK_FLAGS})
 
 # Link with required libraries
-target_link_libraries(fuzz_alloc PUBLIC alloc nbgl io mock)
+target_link_libraries(fuzz_alloc PUBLIC alloc nbgl io mock nbgl_shared)

fuzzing/extra/qrcodegen.cmake

@@ -10,4 +10,4 @@ target_compile_options(fuzz_qrcodegen PUBLIC ${COMPILATION_FLAGS})
 target_link_options(fuzz_qrcodegen PUBLIC ${LINK_FLAGS})
 
 # Link with required libraries
-target_link_libraries(fuzz_qrcodegen PUBLIC qrcode mock)
+target_link_libraries(fuzz_qrcodegen PUBLIC qrcode mock nbgl_shared)

fuzzing/mock/custom/mocks.c

@@ -1,6 +1,9 @@
 
 #include <string.h>
 #include "usbd_core.h"
+#include "nbgl_types.h"
+
+unsigned long gLogger;
 
 size_t strlcpy(char *dst, const char *src, size_t size)
 {
@@ -31,3 +34,14 @@ uint32_t USBD_LL_GetRxDataSize(USBD_HandleTypeDef *pdev __attribute__((unused)),
 {
     return 0;
 }
+
+void nbgl_frontControlAreaMasking(uint8_t mask_index, nbgl_area_t *masked_area_or_null)
+{
+    (void) mask_index;
+    (void) masked_area_or_null;
+}
+
+void mainExit(int exitCode)
+{
+    (void) exitCode;
+}