BUG: fixed "ReferenceError: type is not defined" #968
+164
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug occurs when a new rectangle will be created.
|
@ddproxy Can you please check and merge it? |
shashwatblack
approved these changes
Nov 7, 2019
arnoldtemerdek
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Adding the missing variable declarations ("radius" and "type") would be a great fix. We just updated from Angular 7, Type Script 3.1.6 to Angular 8, Type Script 3.5.3 and we had these errors. With the previous version it was working fine. Our current workaround is quite ugly because we have to override two methods due to these two missing variables.
|
You can also fix this issue by changing your build target (in tsconfig.json) to "es5." Angular CLI 8/9 moving to a target of es2015 seems to have switched the behavior of this code to throwing an error. |
|
When can this problem merge code |
|
This project hasn't been updated in 6 years. So, I doubt it will ever get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug occurs when a new rectangle will be created.