-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Description
The upstream fix was released in Wine 10.14 and can now be installed through the
winehq-devel
.deb package.
@messmerd This is great news! This won't fix local builds, so I'm curious what the timeline should be on removing the no-longer-needed parts... At a glance:
Remove this entire section:
lmms/plugins/VstBase/CMakeLists.txt
Lines 50 to 67 in a1e3098
# If we're building wine-powered RemoteVstPlugins for Linux, # use a custom winebuild to fix ASLR-related VST crashes. # See upstream bug report: https://bugs.winehq.org/show_bug.cgi?id=58480 if(LMMS_BUILD_LINUX AND (LMMS_HAVE_VST_32 OR LMMS_HAVE_VST_64)) ExternalProject_Add(wine GIT_REPOSITORY https://github.com/tresf/wine GIT_TAG 1f8bb63e75baa5c9f901c8f50b4ea9dd69e0baa0 GIT_SHALLOW ON SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/wine" SOURCE_SUBDIR tools/winebuild BUILD_ALWAYS ON BUILD_IN_SOURCE ON INSTALL_COMMAND "" ) ExternalProject_Get_Property(wine SOURCE_DIR) set(CUSTOM_WINEBUILD_EXECUTABLE "${SOURCE_DIR}/tools/winebuild/winebuild") message(STATUS "Using custom winebuild: ${CUSTOM_WINEBUILD_EXECUTABLE}") endif()
Remove --winebuild \"${CUSTOM_WINEBUILD_EXECUTABLE}\"
from this:
"-DCMAKE_CXX_FLAGS=-m32 --winebuild \"${CUSTOM_WINEBUILD_EXECUTABLE}\" -Wb,--disable-dynamicbase"
... but this code will continue to work for local copies with other wine versions, so I'm unsure how soon we should do this.
Thoughts welcome.
Originally posted by @tresf in #7987 (comment)
Metadata
Metadata
Assignees
Labels
No labels