Skip to content

Remove wine fork from codebase #8076

@tresf

Description

@tresf

The upstream fix was released in Wine 10.14 and can now be installed through the winehq-devel .deb package.

@messmerd This is great news! This won't fix local builds, so I'm curious what the timeline should be on removing the no-longer-needed parts... At a glance:

Remove this entire section:

  • # If we're building wine-powered RemoteVstPlugins for Linux,
    # use a custom winebuild to fix ASLR-related VST crashes.
    # See upstream bug report: https://bugs.winehq.org/show_bug.cgi?id=58480
    if(LMMS_BUILD_LINUX AND (LMMS_HAVE_VST_32 OR LMMS_HAVE_VST_64))
    ExternalProject_Add(wine
    GIT_REPOSITORY https://github.com/tresf/wine
    GIT_TAG 1f8bb63e75baa5c9f901c8f50b4ea9dd69e0baa0
    GIT_SHALLOW ON
    SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/wine"
    SOURCE_SUBDIR tools/winebuild
    BUILD_ALWAYS ON
    BUILD_IN_SOURCE ON
    INSTALL_COMMAND ""
    )
    ExternalProject_Get_Property(wine SOURCE_DIR)
    set(CUSTOM_WINEBUILD_EXECUTABLE "${SOURCE_DIR}/tools/winebuild/winebuild")
    message(STATUS "Using custom winebuild: ${CUSTOM_WINEBUILD_EXECUTABLE}")
    endif()

Remove --winebuild \"${CUSTOM_WINEBUILD_EXECUTABLE}\" from this:

... but this code will continue to work for local copies with other wine versions, so I'm unsure how soon we should do this.

Thoughts welcome.

Originally posted by @tresf in #7987 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions