Need help testing #445

[L3MON4D3]

For some details see here, the gist is that it's a pretty big PR, with lots of changes, and I'd love to get some real-world usage on it, if possible :D

[gegoune]

Are any actions/changes required from users apart of simply using the branch?

[L3MON4D3]

Nope, no breaking changes this time :D

[gegoune]

One thing I noticed was that packer builds jsregexp on every PackerSync with rocks = { 'jsregexp' } added. Is that luarocks package strictly necessary?

Other than that all snippets I tried so far work just fine.

[L3MON4D3]

Haven't experienced that yet, I added jsregexp via use_rocks though, maybe that's it.
jsregexp is only necessary for transformations in lsp-snippets, if you don't need that, Luasnip will work just fine without it.
Everything else working sounds good :D

[gegoune]

No idea if I need it. :) But tried using use_rocks and it still gets rebuilt every time I update my plugins.

[L3MON4D3]

Sounds like a packer.nvim-problem :/
Good to know though, for me it always worked after the initial setup, but if you have those problems, they might be common...

[leiserfg]

@L3MON4D3 what do you think of providing jsregexp via ffi as the telescope guys do with telescope-fzf-native.nvim or even providing the pre-built libs like in fzy-lua-native? I still think most of us use nvim+luajit and that will make it easier/more performant, those forced to use PUC can still use the version from rocks.

[L3MON4D3]

Very old for backwards compatibility?

Is very sad to me having to deal with distros not shipping nvim with luajit

Yeah :/ It is how it is

[leiserfg]

Very old for backwards compatibility?

Is very sad to me having to deal with distros not shipping nvim with luajit

Yeah :/ It is how it is

Maybe it does not have to be that old, 2018 should be fine, if someone is using an older system they can build the lib themself.

[leiserfg]

Another option I was thinking of, use the lib built with ffi and in the case of users using PUC they can fall back to https://luarocks.org/modules/colesbury/luaffi which will remove the need for 2 versions of the lib, we just need someone with PUC to test that it actually works.

[L3MON4D3]

Another option I was thinking of, use the lib built with ffi and in the case of users using PUC they can fall back to https://luarocks.org/modules/colesbury/luaffi which will remove the need for 2 versions of the lib, we just need someone with PUC to test that it actually works.

I can see your point, making it easy for most users, but having even more dependencies (which would again have to be installed via luarocks), I don't know...

The more I'm thinking about it, the more seems building jsregexp locally like the safest way to provide it.
Then we'd only have the problem with the build script having to handle both lua and luajit, but for that we could just check which lua is installed via nvim -v.

[L3MON4D3]

I implemented the "build-locally"-approach in parse_from_ast, can you see anything that might fail?