make install_jsregexp on Windows command prompt

[xudyang1]

#1220 @ouch67

[JohnWilliston]

I still have that same problem too FWIW. I still haven’t found any way to get it to stop complaining. I’ve even verified that all the transformations for which the library are required work just fine. So it seems to be used. But the health check keeps complaining. It’s not there.

[xudyang1]

@JohnWilliston Try the following minimal config:

1. mkdir minimal_nvim; cd minimal_nvim
2. touch init.lua, and put the following config into init.lua:

local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
	vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
	vim.fn.system({
		"git",
		"clone",
		"--filter=blob:none",
		"--single-branch",
		"https://github.com/folke/lazy.nvim.git",
		lazypath,
	})
end
vim.opt.runtimepath:prepend(lazypath)

local luasnip_config = {
	"xudyang1/LuaSnip", -- "L3MON4D3/LuaSnip",
	branch = "fix/makefile-SHELL", -- wait to be merged
	lazy = false,
	dependencies = { "rafamadriz/friendly-snippets" },
	build = "make install_jsregexp", -- optional
	config = function()
		local luasnip = require("luasnip")

		luasnip.config.setup()

		require("luasnip.loaders.from_vscode").lazy_load({
			paths = { vim.fn.stdpath("data") .. "/lazy/friendly-snippets" },
		})
	end,
}

local plugins = { luasnip_config }

require("lazy").setup(plugins, {
	root = root .. "/plugins",
})

3. nvim -u init.lua
4. wait until lazy.nvim finishes download
5. Run :checkhealth luasnip in neovim

[xudyang1]

I am not sure if #1343 would fix your issue. The checkhealth issue may be related to your configuration or outdated package. I tested the above configuration on pwsh and cmd, and they worked fine.

[JohnWilliston]

No, I still get the following:

  Failed (1)
    ● LuaSnip 330.92ms  start
        'make' is not recognized as an internal or external command,
        operable program or batch file.

And to be clear, that's in a dev window that can build my projects properly using Visual Studio 2022 from the command line.

[ouch67]

I am not sure if #1343 would fix your issue. The checkhealth issue may be related to your configuration or outdated package. I tested the above configuration on pwsh and cmd, and they worked fine.

So that patch #1343 does fix some things as long as you make the following changes to the makefile:

Line 81 [LUA_LDLIBS?=]: change the double quotes to single quotes.
Line 94 [$(MAKE)]: change the single quotes to double quotes.
Line 95 [$(MAKE)]: change the single quotes to double quotes.

This however, does not fix checkhealth complaining about missing jsregexp library.

[JohnWilliston]

LOL! In the end it still gripes about the missing thing that's there, eh? Love it.

[xudyang1]

@ouch67 @JohnWilliston Does the new fix #1346 work?

local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
	vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
	vim.fn.system({
		"git",
		"clone",
		"--filter=blob:none",
		"--single-branch",
		"https://github.com/folke/lazy.nvim.git",
		lazypath,
	})
end
vim.opt.runtimepath:prepend(lazypath)

local luasnip_config = {
	"xudyang1/LuaSnip", -- "L3MON4D3/LuaSnip",
	branch = "fix/win-shell", -- wait to be merged
	lazy = false,
	dependencies = { "rafamadriz/friendly-snippets" },
	build = "make install_jsregexp", -- optional
	config = function()
		local luasnip = require("luasnip")

		luasnip.config.setup()

		require("luasnip.loaders.from_vscode").lazy_load({
			paths = { vim.fn.stdpath("data") .. "/lazy/friendly-snippets" },
		})
	end,
}

local plugins = { luasnip_config }

require("lazy").setup(plugins, {
	root = root .. "/plugins",
})

[ouch67]

It does not. First I needed to make the quote changes mentioned above to the makefile in order to get it to build.

And once you do that checkhealth throws an error and complains about missing a module called luasnip.health.

Full error:

- ❌ ERROR Failed to run healthcheck for "luasnip" plugin. Exception:
  [string "require("luasnip.health").check()"]:1: module 'luasnip.health' not found:
  	no field package.preload['luasnip.health']
  	cache_loader: module 'luasnip.health' not found
  	cache_loader_lib: module 'luasnip.health' not found
  	no file '.\luasnip\health.lua'
  	no file 'C:\Program Files\Neovim\bin\lua\luasnip\health.lua'
  	no file 'C:\Program Files\Neovim\bin\lua\luasnip\health\init.lua'
  	no file 'C:\Users\[User Name]\AppData\Local\nvim-data/lazy-rocks/telescope.nvim/share/lua/5.1/luasnip\health.lua'
  	no file 'C:\Users\[User Name]\AppData\Local\nvim-data/lazy-rocks/telescope.nvim/share/lua/5.1/luasnip\health/init.lua'
  	no file '.\luasnip\health.dll'
  	no file 'C:\Program Files\Neovim\bin\luasnip\health.dll'
  	no file 'C:\Program Files\Neovim\bin\loadall.dll'
  	no file 'C:\Users\[User Name]\AppData\Local\nvim-data/lazy-rocks/telescope.nvim/lib/lua/5.1/luasnip\health.dll'
  	no file 'C:\Users\[User Name]\AppData\Local\nvim-data/lazy-rocks/telescope.nvim/lib64/lua/5.1/luasnip\health.dll'
  	no file 'C:/Users/[User Name]/AppData/Local/nvim-data/lazy/blink.cmp/lua/blink/cmp/fuzzy/rust/../../../../../target/release/libluasnip\health.dll'
  	no file 'C:/Users/[User Name]/AppData/Local/nvim-data/lazy/blink.cmp/lua/blink/cmp/fuzzy/rust/../../../../../target/release/luasnip\health.dll'
  	no file '.\luasnip.dll'
  	no file 'C:\Program Files\Neovim\bin\luasnip.dll'
  	no file 'C:\Program Files\Neovim\bin\loadall.dll'
  	no file 'C:\Users\[User Name]\AppData\Local\nvim-data/lazy-rocks/telescope.nvim/lib/lua/5.1/luasnip.dll'
  	no file 'C:\Users\[User Name]\AppData\Local\nvim-data/lazy-rocks/telescope.nvim/lib64/lua/5.1/luasnip.dll'
  	no file 'C:/Users/[User Name]/AppData/Local/nvim-data/lazy/blink.cmp/lua/blink/cmp/fuzzy/rust/../../../../../target/release/libluasnip.dll'
  	no file 'C:/Users/[User Name]/AppData/Local/nvim-data/lazy/blink.cmp/lua/blink/cmp/fuzzy/rust/../../../../../target/release/luasnip.dll'

Note: I also tried it with removing C:/Program Files/Git/bin from my path variable. And I ended up having to edit line 47 to be:

ifeq (,$(WIN_GIT_SHELL))

In order to to get it to find my sh.exe

[JohnWilliston]

It's still complaining make is not recognized as a command, when I have make installed. Windows is such shite.

[xudyang1]

@ouch67 Can you try the minimal init.lua provided above, so we can narrow down where the bug is triggered.

[xudyang1]

It's still complaining make is not recognized as a command, when I have make installed. Windows is such shite.

How did you install make? Is it in the $PATH?

[JohnWilliston]

I installed GNU make 4.4.1 using Chocolatey for provisioning via the choco install make command. Yes, it's on the path. I'm so sick of fighting Windows stupidity when all this works fine on *nix and macOS without all this garbage fiddling around.

[ouch67]

ok, so I finally had a chance to try out the minimal init.lua.

So the only thing I had to change in it is:
Line 27: make to mingw32-make

I'm using Mingw64 which strangely does not include an executable called "make".

And I get the exact same results.

I have to make the quote changes above which are:
Line 81 [LUA_LDLIBS?=]: change the double quotes to single quotes.
Line 94 [$(MAKE)]: change the single quotes to double quotes.
Line 95 [$(MAKE)]: change the single quotes to double quotes.

and then it compiles fine but checkhealth still complains that it cannot find jsregexp.

and John you need install a c/c++ compiler. I would recommend microsoft's but if you don't like the licensing on it you can give mingw64 a go. That version of make is over 2 years old. I'm not sure it could even read a modern makefile. But it wouldn't be able to do anything with it anyway because you don't have a compiler installed.

[JohnWilliston]

For the record, I have the Mingw64, gcc, and Microsoft Visual Studio 2022 installed. Having tools isn't the problem.

[ouch67]

You need to add your mingw64 \bin directory to your PATH environment variable. And if you have done that already then mingw64 doesn't include a "make" executable. You need to change any mention of "make" in your config files to use mingw32-make particularly init.lua. You could alternatively just make a copy of mingw32-make and rename it to make. But that would make it conflict with your MSVS install if you have added that to your path or decide to later.

[JohnWilliston]

Thanks for all your diligent aid. I think it's not worth my time to fix at this point, given that even when I do get jsregexp building, I'm still given the spurious warning :/ But I do really appreciate the help.

[xudyang1]

@ouch67 , what was reported from :checkhealth luasnip with the minimal init.lua, the error should not be identical with the one produced by your own config.

[xudyang1]

Make sure clean up the old build when you test the minimal init.lua:

nvim -u init.lua # previous run
rm -rf .repro # cleanup old build
nvim -u init.lua # test new commit to PR

[xudyang1]

I tested with mingw that bundles make and gcc:

winget install Git.Git; # C:/Program Files/Git, and no `sh.exe` in $PATH by default
winget install -e --id Neovim.Neovim; # C:/Program Files/Neovim, which adds %Neovim/bin% to $PATH by default
scoop install mingw # comes with make.exe and gcc.exe
neovim -u init.lua # then :checkhealth luasnip reports `OK`

I don't have mingw32-make in mingw environment, how did you install the executable?