Skip to content

Commit c7dba3d

Browse files
committed
test(volume-rendering): fix volume rendering lighting change test failure
Fix for volume rendering test failure due to change in lighting method. Updated the baseline test image, and also fixed a bug caused by a typo in 'vtkTrilinearOn' macro in vtkVolumeFS.glsl. fix #2101
1 parent 328af12 commit c7dba3d

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

Sources/Rendering/OpenGL/VolumeMapper/test/testLighting.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ test.onlyIfWebGL('Test Lighted Volume Rendering', (t) => {
101101
[baseline1, baseline2],
102102
'Rendering/OpenGL/VolumeMapper/testMultiComponentComposite',
103103
t,
104-
1.5,
104+
0.05,
105105
gc.releaseResources
106106
);
107107
});
5.91 KB
Loading

Sources/Rendering/OpenGL/glsl/vtkVolumeFS.glsl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ varying vec3 vertexVCVSOutput;
2727
// always set vtkNumComponents 1,2,3,4
2828
//VTK::NumComponents
2929

30-
// possibly define vtkUseTriliear
30+
// possibly define vtkTrilinearOn
3131
//VTK::TrilinearOn
3232

3333
// possibly define vtkIndependentComponents
@@ -224,8 +224,8 @@ uniform int xreps;
224224
uniform int xstride;
225225
uniform int ystride;
226226

227-
// if computing triliear values from multiple z slices
228-
#ifdef vtkTriliearOn
227+
// if computing trilinear values from multiple z slices
228+
#ifdef vtkTrilinearOn
229229
vec4 getTextureValue(vec3 ijk)
230230
{
231231
float zoff = 1.0/float(volumeDimensions.z);

0 commit comments

Comments
 (0)