Fix summaries and fix missing text versions of models #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodePerformanceTestandPlaysetLightTestwere missing text-based.gltfversions of the assets, so the PHP script was producing warnings for these when ran on all files. This PR adds text-based versions to fix these warnings.CorsetandStainedGlassLampwere both missing descriptions in the JSON metadata. This PR adds them, based on the text already present in the README.body.md files.The Darmstadt Graphics Group GmbH legal mark license was missing validation in the PHP script. This caused the PHP script to produce invalid license text in the
.reuse/dep5file. This PR adds a case for this license, similar to the existing code for Cesium, Khronos, and UX3D.