Added OSX link and unlink targets to include libs locally (WIP) #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radujipa
changed the title
Ealdwulf
reviewed
Oct 12, 2016
| clean: clean-release clean-debug | ||
| link: all # for Mac OS | ||
| mkdir -p /usr/local/include/kano | ||
| ln -fs `pwd`/includes/kano/* /usr/local/include/kano |
There was a problem hiding this comment.
After discussion with @tombettany , the main objection to this PR is these lines which potentially overwrite or delete stuff in /usr/local. These can be fixed by
changing it to say
-ln -spwd/includes/kano/* /usr/local/include/kano
Which will silently do nothing if the link is already there.
Ealdwulf
reviewed
Oct 12, 2016
| ln -fs `pwd`/release/$(SONAME) /usr/local/lib | ||
|
|
||
| unlink: all # for Mac OS | ||
| rm -rf /usr/local/include/kano/networking |
There was a problem hiding this comment.
Similarly, these rm commands should be replaced with find:
find /usr/local/include/kano/networking -xdev -type l -delete
IE, only delete symlinks.
| @rm -f $(DEBUG_OUTDIR)/$(SONAME) | ||
|
|
||
| clean: clean-release clean-debug | ||
| link: all # for Mac OS |
| @rm -f $(DEBUG_OUTDIR)/$(SONAME) | ||
|
|
||
| clean: clean-release clean-debug | ||
| link: all # for Mac OS |
| @rm -f $(DEBUG_OUTDIR)/$(SONAME) | ||
|
|
||
| clean: clean-release clean-debug | ||
| link: all # for Mac OS |
|
Closing to reopen against master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/KanoComputing/os-dashboard/pull/243
WIP: