kano-settings-onboot: Fix logging traceback

If the boot configuration was being detected as corrupted, a logging
message would be written but this would fail as the `warning()` method
wasn't defined on the `logger` object. Resolve this by switching to use
the defined `warn()` message.

Author: tombettany

bin/kano-settings-onboot

@@ -78,7 +78,7 @@ def main(args):
 
     # Check for corrupt config file.
     if check_corrupt_config():
-        logger.warning('Found corrupt config file! Restored to default.')
+        logger.warn('Found corrupt config file! Restored to default.')
         reboot(dry_run=dry_run)
         return RC_SUCCESS
 

debian/changelog

@@ -6,6 +6,7 @@ kano-settings (4.1.0-0) unstable; urgency=low
   * Fix inconsistent Settings > Display > Resolution: Auto behaviour for
     displays with corrupted EDID
   * Switch to use the "dtparam" value to check for config.txt corruption
+  * Fix corrupt config.txt logging message
 
  -- Team Kano <[email protected]>  Thu, 27 Sep 2018 12:11:00 +0100
 

kano_settings/boot_config.py

@@ -400,7 +400,7 @@ def _clean_up_exit(self):
 
         if self.state > 1:
             self.close()
-            raise OpenTransactionError()
+            raise OpenTransactionError('Transaction file left open')
 
     def abort(self):
         os.remove(self.temp_path)