ESLint: use the --rulesdir option for internal rules.

Motivation: We need to have a way to have internal ESLint rules.
ESLint allows you to import rules in two ways:
1. As an npm package, it is problematic for internal rules since we don't want to publish it on NPM. So in the past, we used NPM-specific workarounds to treat a directory as a package.
2. `--rulesdir` CLI option, the problem with it is deprecated.

ESLint team is planning to deprecate the current config format and switch to:
https://eslint.org/docs/latest/use/configure/configuration-files-new
This format forces you to import plugins manually, and it entirely resolves our problem with internal rules. But it requires that all plugins that we use to support this format.

I propose to temporarily switch to `--rulesdir` and start working on changing to the new format since the entire config format will be deprecated anyway.
This switch will unblock support for node@19 in CI and local development and unblock graphql#3848.

Author: IvanGoncharov

.eslintrc.yml

@@ -5,7 +5,6 @@ env:
   shared-node-browser: true
 reportUnusedDisableDirectives: true
 plugins:
-  - internal-rules
   - node
   - import
   - simple-import-sort
@@ -22,9 +21,9 @@ rules:
   # See './resources/eslint-internal-rules/README.md'
   ##############################################################################
 
-  internal-rules/only-ascii: error
-  internal-rules/no-dir-import: error
-  internal-rules/require-to-string-tag: off
+  only-ascii: error
+  no-dir-import: error
+  require-to-string-tag: off
 
   ##############################################################################
   # `eslint-plugin-node` rule list based on `v11.1.x`
@@ -658,10 +657,10 @@ overrides:
       '@typescript-eslint/type-annotation-spacing': off
   - files: 'src/**'
     rules:
-      internal-rules/require-to-string-tag: error
+      require-to-string-tag: error
   - files: 'src/**/__*__/**'
     rules:
-      internal-rules/require-to-string-tag: off
+      require-to-string-tag: off
       node/no-unpublished-import: [error, { allowModules: ['chai', 'mocha'] }]
       import/no-deprecated: off
       import/no-restricted-paths: off
@@ -700,7 +699,7 @@ overrides:
     env:
       node: true
     rules:
-      internal-rules/only-ascii: [error, { allowEmoji: true }]
+      only-ascii: [error, { allowEmoji: true }]
       node/no-unpublished-import: off
       node/no-sync: off
       import/no-namespace: off

package-lock.json

@@ -35,7 +35,7 @@
     "changelog": "ts-node resources/gen-changelog.ts",
     "benchmark": "ts-node resources/benchmark.ts",
     "test": "npm run lint && npm run check && npm run testonly:cover && npm run prettier:check && npm run check:spelling && npm run check:integrations",
-    "lint": "eslint --cache --max-warnings 0 .",
+    "lint": "eslint --cache --max-warnings 0 --rulesdir resources/eslint-internal-rules/ .",
     "check": "tsc --pretty",
     "testonly": "mocha --full-trace src/**/__tests__/**/*-test.ts",
     "testonly:cover": "c8 npm run testonly",
@@ -75,7 +75,6 @@
     "docusaurus-plugin-typedoc-api": "2.5.0",
     "eslint": "8.27.0",
     "eslint-plugin-import": "2.26.0",
-    "eslint-plugin-internal-rules": "file:./resources/eslint-internal-rules",
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-react": "7.31.10",
     "eslint-plugin-react-hooks": "4.6.0",

package.json

@@ -14,7 +14,6 @@ fs.writeFileSync(tmpDirPath('package.json'), JSON.stringify(packageJSON));
 
 copyToTmpDir('package-lock.json');
 copyToTmpDir('tsconfig.json');
-copyToTmpDir('resources/eslint-internal-rules');
 copyToTmpDir('src');
 copyToTmpDir('website');