Update dependency on cardano-ledger-specs #1840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
force-pushed
the
mrBliss/update-cardano-ledger-specs
branch
from
a0531b4 to
231509a
Compare
intricate
approved these changes
Mar 24, 2020
nc6
approved these changes
Mar 24, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 24, 2020
1627: CancelIoEx and overal review of Win32-network r=coot a=coot The primary goal of this PR was to add `CancelIoEx` to fix #1574. In doing so I changed the interface and the end result is that: * we don't use C type level wrappers for windows syscalls any more (apart from `GetQueuedCompletionStatus` where we need to use a windwo kernel C macro. * using `GADTs` to ensure that we use the right combination of `OVERLAPPED` / `WSAOVERLAPPED`, `HANDLE` / `SOCKET` and `ErrCode` / `WsaErrCode`. * there is a closed type family which ensures that some of the `castPtr` usage is actually safe, it is not exposed. It could be removed, but then using `castPtr` would leak out to various modules - so I preferred the more elegant and local, though type havier approach. * more tests, especially for error conditions in which we need to assure that we are not deallocating the stable pointer twice 💣 This PR is done on top of `coot/windows-vectored-io` (and it merges into that branch) - this makes the scope of this PR adequate for the proposed changes. For the moment the windows stuff is stacked on CI, but when devops will help with it I will be able to merge all the PRs in turn. 1840: Update dependency on cardano-ledger-specs r=mrBliss a=mrBliss Co-authored-by: Marcin Szamotulski <[email protected]> Co-authored-by: Thomas Winant <[email protected]>
Build failed (retrying...) |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 24, 2020
1840: Update dependency on cardano-ledger-specs r=mrBliss a=mrBliss Co-authored-by: Thomas Winant <[email protected]>
Build failed |
mrBliss
force-pushed
the
mrBliss/update-cardano-ledger-specs
branch
from
231509a to
fcc6130
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.