feat(IamAssumeAuthenticator): introduce new authenticator type #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padamstx
force-pushed
the
iam-assume
branch
2 times, most recently
from
9cc61e0 to
5192fea
Compare
padamstx
commented
Oct 1, 2024
src/test/java/com/ibm/cloud/sdk/core/test/security/ConfigBasedAuthenticatorFactoryTest.java
Show resolved
Hide resolved
padamstx
commented
Oct 1, 2024
src/test/java/com/ibm/cloud/sdk/core/test/security/ConfigBasedAuthenticatorFactoryTest.java
Show resolved
Hide resolved
pyrooka
approved these changes
Oct 2, 2024
Member
pyrooka
left a comment
pyrooka
left a comment
There was a problem hiding this comment.
Looks good! Just one thing I'd like to mention: in the Authentication.md I found 4 typos - outside of you changes. It's the verificaton. If you think you can fix those in this PR, totally up to you. :)
This commit introduces the new IamAssumeAuthenticator which will fetch an IAM access token using the IAM getToken operation's "assume" grant type. The resulting access token allows the application to assume the identity of a trusted profile, similar to the "sudo" feature of Linux. Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
Contributor
Author
fixed |
Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
Contributor
Author
|
Just pushed the commit with the immutable-related changes. I'll request a re-review... |
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Oct 15, 2024
# [9.22.0](9.21.2...9.22.0) (2024-10-15) ### Features * **IamAssumeAuthenticator:** introduce new authenticator type ([#227](#227)) ([35abbf0](35abbf0))
Contributor
|
🎉 This PR is included in version 9.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the new IamAssumeAuthenticator which will fetch an IAM access token using the IAM getToken operation's "assume" grant type. The resulting access token allows the application to assume the identity of a trusted profile, similar to the "sudo" feature of Linux.