-
Notifications
You must be signed in to change notification settings - Fork 1
feat: load web wallet using the read-only token #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andreabadesso
wants to merge
74
commits into
master
Choose a base branch
from
feat/read-only-xpub
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7,526
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dokploy Preview Deployment
|
ada3722 to
eaa08a4
Compare
eaa08a4 to
c9fbbf6
Compare
Dokploy Preview Deployment
|
fb7c587 to
11d7127
Compare
11d7127 to
9891146
Compare
d6ebc7b to
6f7589e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-10-30.at.10.00.28.1.mov
Acceptance Criteria
waitReadyparameter that will return early iffalse(defaults to true). It will return as soon as the wallet is created in the wallet-service and isstartReadOnlymethod that will start a wallet facade using thexpubkeynew auth mechanism.startReadOnlymethod will wait until the wallet isreadyand fail if it wasn't previously initializedChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged