Skip to content

Commit 3461926

Browse files
committed
Fix navigation .load grabbing the function instead of executing it for incoming and replace elements
1 parent e1f5809 commit 3461926

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

dist/jpack.bundled.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/jpack.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

es/navigation/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ export const navigation = {
224224
* @param url
225225
* @param data
226226
* @param onload
227-
* @param options {incomingElement, replaceElement, pushState}
227+
* @param options:{incomingElement, replaceElement, pushState}
228228
*/
229229
load: function (url, data = {}, onload, options = {}) {
230230
const self = this;
@@ -233,8 +233,8 @@ export const navigation = {
233233
type_checks.isDataObject(options, ['incomingElement', 'replaceElement', 'pushState'], false, true, true);
234234

235235
//set values
236-
const incomingElement = typeof options.incomingElement !== "undefined" ? options.incomingElement : this.getIncomingElement;
237-
const replaceElement = typeof options.replaceElement !== "undefined" ? options.replaceElement : this.getReplaceElement;
236+
const incomingElement = typeof options.incomingElement !== "undefined" ? options.incomingElement : this.getIncomingElement();
237+
const replaceElement = typeof options.replaceElement !== "undefined" ? options.replaceElement : this.getReplaceElement();
238238
const pushState = typeof options.pushState !== "undefined" ? options.pushState : this.pushState;
239239

240240
//cache route (axios is async)

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@htmlguyllc/jpack",
3-
"version": "9.0.18",
3+
"version": "9.0.19",
44
"description": "Core Javascript Library of Everyday Objects, Events, and Utilities",
55
"keywords": [
66
"javascript",

test/_jpack.bundled.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)