Skip to content

perf(gix-utils): add normalization fast path #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2025
Merged

perf(gix-utils): add normalization fast path #2120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions gix-utils/src/str.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ use std::{borrow::Cow, ffi::OsStr, path::Path};
///
/// At the expense of extra-compute, it does nothing if there is no work to be done, returning the original input without allocating.
pub fn precompose(s: Cow<'_, str>) -> Cow<'_, str> {
use unicode_normalization::UnicodeNormalization;
if s.as_ref().nfc().cmp(s.as_ref().chars()).is_eq() {
use unicode_normalization::{is_nfc, UnicodeNormalization};
if is_nfc(s.as_ref()) {
s
} else {
Cow::Owned(s.as_ref().nfc().collect())
Expand All @@ -16,8 +16,8 @@ pub fn precompose(s: Cow<'_, str>) -> Cow<'_, str> {
///
/// At the expense of extra-compute, it does nothing if there is no work to be done, returning the original input without allocating.
pub fn decompose(s: Cow<'_, str>) -> Cow<'_, str> {
use unicode_normalization::UnicodeNormalization;
if s.as_ref().nfd().cmp(s.as_ref().chars()).is_eq() {
use unicode_normalization::{is_nfd, UnicodeNormalization};
if is_nfd(s.as_ref()) {
s
} else {
Cow::Owned(s.as_ref().nfd().collect())
Expand Down
Loading