Removed "Version" variable (users should pick one of the existing ones)

Author: GeertvanHorrik

GitVersionCore/OutputVariables/VariableProvider.cs

@@ -28,7 +28,6 @@ public static class VariableProvider
         public const string OriginalRelease = "OriginalRelease";
 
         // Synonyms
-        public const string Version = "Version";
         public const string NuGetVersionV2 = "NuGetVersionV2";
         public const string NuGetVersionV3 = "NuGetVersionV3";
         public const string NuGetVersion = "NuGetVersion";
@@ -73,9 +72,6 @@ public static Dictionary<string, string> GetVariablesFor(
                     bmd.ReleaseDate.OriginalDate.UtcDateTime.ToString("u"))},
             };
 
-            // Synonyms to ensure backwards compatibility
-            variables[Version] = variables[LegacySemVer];
-
             // Use ToLower() to fix a bug where Beta and beta are different in NuGet
             variables[NuGetVersionV2] = variables[LegacySemVerPadded].ToLower();
             //variables[NuGetVersionV3] = variables[LegacySemVerPadded].ToLower(); // TODO: when v3 is released, determine what to use

GitVersionTask/GetVersion.cs

@@ -74,9 +74,6 @@ public class GetVersion : Task
         [Output]
         public string OriginalRelease { get; set; }
 
-        [Output]
-        public string Version { get; set; }
-
         [Output]
         public string NuGetVersionV2 { get; set; }
 

Tests/AssemblyInfoBuilderTests.VerifyAssemblyVersion_Major.approved.txt

@@ -44,7 +44,6 @@ static class GitVersionInformation
     public static string AssemblyVersion = "2.0.0.0";
     public static string AssemblyFileVersion = "2.3.4.0";
     public static string OriginalRelease = "originalCommitSha.2014-03-01 00:00:01Z";
-    public static string Version = "2.3.4";
     public static string NuGetVersionV2 = "2.3.4";
     public static string NuGetVersion = "2.3.4";
 

Tests/AssemblyInfoBuilderTests.VerifyAssemblyVersion_MajorMinor.approved.txt

@@ -44,7 +44,6 @@ static class GitVersionInformation
     public static string AssemblyVersion = "2.3.0.0";
     public static string AssemblyFileVersion = "2.3.4.0";
     public static string OriginalRelease = "originalCommitSha.2014-03-01 00:00:01Z";
-    public static string Version = "2.3.4";
     public static string NuGetVersionV2 = "2.3.4";
     public static string NuGetVersion = "2.3.4";
 

Tests/AssemblyInfoBuilderTests.VerifyAssemblyVersion_MajorMinorPatch.approved.txt

@@ -44,7 +44,6 @@ static class GitVersionInformation
     public static string AssemblyVersion = "2.3.4.0";
     public static string AssemblyFileVersion = "2.3.4.0";
     public static string OriginalRelease = "originalCommitSha.2014-03-01 00:00:01Z";
-    public static string Version = "2.3.4";
     public static string NuGetVersionV2 = "2.3.4";
     public static string NuGetVersion = "2.3.4";
 

Tests/AssemblyInfoBuilderTests.VerifyAssemblyVersion_None.approved.txt

@@ -44,7 +44,6 @@ static class GitVersionInformation
     public static string AssemblyVersion = "1.0.0.0";
     public static string AssemblyFileVersion = "2.3.4.0";
     public static string OriginalRelease = "originalCommitSha.2014-03-01 00:00:01Z";
-    public static string Version = "2.3.4";
     public static string NuGetVersionV2 = "2.3.4";
     public static string NuGetVersion = "2.3.4";
 

Tests/AssemblyInfoBuilderTests.VerifyCreatedCode.approved.txt

@@ -44,7 +44,6 @@ static class GitVersionInformation
     public static string AssemblyVersion = "1.2.3.0";
     public static string AssemblyFileVersion = "1.2.3.0";
     public static string OriginalRelease = "originalCommitSha.2014-03-01 00:00:01Z";
-    public static string Version = "1.2.3-unstable4";
     public static string NuGetVersionV2 = "1.2.3-unstable0004";
     public static string NuGetVersion = "1.2.3-unstable0004";
 

Tests/JsonVersionBuilderTests.Json.approved.txt

@@ -20,7 +20,6 @@
   "AssemblyVersion":"1.2.3.0",
   "AssemblyFileVersion":"1.2.3.0",
   "OriginalRelease":"originalCommitSha.2014-03-01 00:00:01Z",
-  "Version":"1.2.3-unstable4",
   "NuGetVersionV2":"1.2.3-unstable0004",
   "NuGetVersion":"1.2.3-unstable0004"
 }

Tests/VariableProviderTests.cs

@@ -73,7 +73,6 @@ public void AssemblyVersion(
         vars[VariableProvider.AssemblyVersion].ShouldBe(version);
         vars[VariableProvider.AssemblyFileVersion].ShouldBe(fileVersion);
 
-        vars[VariableProvider.Version].ShouldBe(vars[VariableProvider.LegacySemVer]);
         vars[VariableProvider.NuGetVersionV2].ShouldBe(vars[VariableProvider.LegacySemVerPadded].ToLower());
         vars[VariableProvider.NuGetVersion].ShouldBe(vars[VariableProvider.NuGetVersionV2]);
     }