This repository was archived by the owner on Dec 5, 2024. It is now read-only.
fix: setPopperNode only to update popper instance for HTMLElement
#253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piecyk
commented
Dec 8, 2018
piecyk
changed the title
setPopperNode only to update popper instance when for HTMLElementsetPopperNode only to update popper instance for HTMLElement
FezVrasta
reviewed
Dec 8, 2018
piecyk
commented
Dec 8, 2018
piecyk
force-pushed
the
fix-popperNode
branch
from
619913d to
e75aeff
Compare
piecyk
changed the title
setPopperNode only to update popper instance for HTMLElementsetPopperNode only to update popper instance for HTMLElement
|
When looking closer found out that we have some not needed renders in Popper when placement is not changed. Small change piecyk@9d44f51 https://codesandbox.io/s/3989zky8q I know the |
|
@FezVrasta What do you think about this ? |
|
It looks good to me, is it ready to be merged? |
|
Yep, squash and merge 👍 |
|
Did you checkout this comment #253 (comment) ? |
|
Don't you want to address that in a different PR? |
|
Yes, will do 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #250
@FezVrasta have a look, need to tweak bit the popper.js mock. We want to call
updateStateModifierbecause it was triggering the infinite loop with setState, after the instance was recreated... Also updated few types to be more strict from?HTMLElementtoHTMLElement | nullas the void type is not quite correct there.